You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/28 20:41:52 UTC
[GitHub] [trafficserver] sudheerv opened a new pull request #7909: Add hit stats for remap rules
sudheerv opened a new pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909
Ordering of remap rules in remap.config in an efficient manner is
very important as it can have a significant impact on performance and
throughput that can be achieved using ATS as a proxy server. For example,
ATS uses a prefix trie to match a forward map rule, but, has to run
through the regex_map rules sequentially. Interleaving regex_map rules
with forward map rules can thus result in unnecessary overhead when
those rules are not overlapping. Further, within regex_map rules, as far
as possible ordering them based on their "hit" rate (decreasing order) can
result in a significant performance improvement. This change adds stats
to track hit rate for each remap rule (based on their line number/rank in the
remap.config file) to allow for such visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850718096
[approve ci FreeBsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850717876
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850718246
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv removed a comment on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv removed a comment on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850717876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-854155414
> Could you add some documentation on the new config and related metrics?
I thought a little bit more and switched the patch to support an endpoint based stat output as using the standard metrics has some limitations - doesn't work for remap reloads, the stat names are not very intuitive and require an additional mapping of rank to remap etc.
New PR is here:
https://github.com/apache/trafficserver/pull/7918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850736058
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850718179
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-865409964
Replaced by #7936.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-854155414
> Could you add some documentation on the new config and related metrics?
I thought a little bit more and switched the patch to support an endpoint based stat output as using the standard metrics has some limitations - doesn't work for remap reloads, the stat names are not very intuitive and require an additional mapping of rank to remap etc.
New PR is here:
https://github.com/apache/trafficserver/pull/7918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-865409964
Replaced by #7936.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv removed a comment on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv removed a comment on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850736058
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850717986
[approve ci ubuntu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode closed pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode closed pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-852474605
Could you add some documentation on the new config and related metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] sudheerv commented on pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
sudheerv commented on pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909#issuecomment-850718311
[approve ci debian]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode closed pull request #7909: Add hit stats for remap rules
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode closed pull request #7909:
URL: https://github.com/apache/trafficserver/pull/7909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org