[jira] [Commented] (HBASE-15524) Fix NPE in client-side metrics

["Elliott Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209569#comment-15209569 ] 

Elliott Clark commented on HBASE-15524:
---------------------------------------

Can we do the same try/catch-log for receiveMultiAction calling updateServerStats. While it wasn't the cause this time it would be good to protect against the same issue.

Other than that looks good to me. We need to clean up the client sooooo much.

> Fix NPE in client-side metrics
> ------------------------------
>
>                 Key: HBASE-15524
>                 URL: https://issues.apache.org/jira/browse/HBASE-15524
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, metrics
>    Affects Versions: 1.3.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>            Priority: Critical
>             Fix For: 1.3.0
>
>         Attachments: HBASE-15524-branch-1.3.v1.patch
>
>
> java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.client.MetricsConnection.incrCacheDroppingExceptions(MetricsConnection.java:458)
> 	at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.updateCachedLocations(ConnectionManager.java:2256)
> 	at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.receiveGlobalFailure(AsyncProcess.java:1179)
> 	at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.access$1200(AsyncProcess.java:600)
> 	at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:743)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)