You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Edith Chevrier <ed...@wyona.com> on 2004/12/08 17:37:59 UTC
Re: removing XPSAssembler in 1.4
The xlink transformer doesn't work with the new xalan, some problem with
namespaces. If we set the setNormalizeNamespaces to true instead of
false in the AbstractDOMTransformer, it works now again. Can I check in
this change?
Edith
Michael Wechner wrote:
> Gregor J. Rothfuss wrote:
>
>> Michael Wechner wrote:
>>
>>> The XPSAssembler does does recursive inclusion with loop check, etc.
>>>
>>> It's much more reliable than the XInclude and CInclude processor
>>> from Cocoon itself.
>>>
>>> Instead of removing it I would rather suggest that we refactor it re
>>> Cocoon adoption.
>>>
>>> This will be way less work than re-implementing everything into
>>> XInclude and CInclude of Cocoon itself.
>>>
>>> It basically requires two steps:
>>>
>>> 1) migrate from the xlink to the xinclude syntax (which is rather a
>>> search and replace)
>>>
>>> 2) Refactor it as a Cocoon component, such that the Cocoon protocol
>>> can be used and doesn't has to be faked with http
>>
>>
>>
>> fair enough. i'll take a look at what it takes.
>
>
>
> Please let me know if I can help.
>
> Maybe a first step would be to rename the thing, e.g.
>
> from
>
> src/java/org/apache/lenya/xml/XPSAssembler.java
>
> to
>
> src/java/org/apache/lenya/xml/XInclude.java
>
> Please note that this Java class has nothing to do with a Cocoon
> Transformer,
> but takes care of the XInclude itself.
>
> It's then being used by
>
> src/java/org/apache/lenya/cms/cocoon/transformation/IncludeTransformer.java
>
>
> The problem here might be how to insert the Cocoon protocol, but the
> XPSAssembler is using
>
> src/java/org/apache/lenya/xml/XPSSourceInformation.java
>
> which can be inherited for a different protocol.
>
> Michi
>
>>
>>
>
>
--
Edith Chevrier
Wyona Inc. - Open Source Content Management - Apache Lenya
http://wyona.com http://lenya.apache.org
edith.chevrier@wyona.com edith@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Apache Lenya Project http://lenya.apache.org
Re: removing XPSAssembler in 1.4
Posted by Antonio Gallardo <ag...@agssa.net>.
On Mie, 8 de Diciembre de 2004, 11:06, Edith Chevrier dijo:
> Gregor J. Rothfuss wrote:
>
>> Edith Chevrier wrote:
>>
>>> The xlink transformer doesn't work with the new xalan, some problem
>>> with namespaces. If we set the setNormalizeNamespaces to true instead
>>> of false in the AbstractDOMTransformer, it works now again. Can I
>>> check in this change?
>>
>>
>> if we do this, then our AbstractDOMTransformer is no longer needed:
>>
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=27331
>>
>> it is easier to just remove it (take a look at how it is done in 1.4)
>>
> Exactly.
> So I remove it and close the bug.
Yep. ;-)
Best Regards,
Antonio Gallardo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Apache Lenya Project http://lenya.apache.org
Re: removing XPSAssembler in 1.4
Posted by Edith Chevrier <ed...@wyona.com>.
Gregor J. Rothfuss wrote:
> Edith Chevrier wrote:
>
>> The xlink transformer doesn't work with the new xalan, some problem
>> with namespaces. If we set the setNormalizeNamespaces to true instead
>> of false in the AbstractDOMTransformer, it works now again. Can I
>> check in this change?
>
>
> if we do this, then our AbstractDOMTransformer is no longer needed:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=27331
>
> it is easier to just remove it (take a look at how it is done in 1.4)
>
Exactly.
So I remove it and close the bug.
Edith
--
Edith Chevrier
Wyona Inc. - Open Source Content Management - Apache Lenya
http://wyona.com http://lenya.apache.org
edith.chevrier@wyona.com edith@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Apache Lenya Project http://lenya.apache.org
Re: removing XPSAssembler in 1.4
Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
Edith Chevrier wrote:
> The xlink transformer doesn't work with the new xalan, some problem with
> namespaces. If we set the setNormalizeNamespaces to true instead of
> false in the AbstractDOMTransformer, it works now again. Can I check in
> this change?
if we do this, then our AbstractDOMTransformer is no longer needed:
http://issues.apache.org/bugzilla/show_bug.cgi?id=27331
it is easier to just remove it (take a look at how it is done in 1.4)
--
Gregor J. Rothfuss
COO, Wyona Content Management Solutions http://wyona.com
Apache Lenya http://lenya.apache.org
gregor.rothfuss@wyona.com gregor@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Apache Lenya Project http://lenya.apache.org