[jira] [Work logged] (GOBBLIN-830) update config key to define job launcher type

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-830?focusedWorklogId=305330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305330 ]

ASF GitHub Bot logged work on GOBBLIN-830:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Sep/19 21:38
            Start Date: 02/Sep/19 21:38
    Worklog Time Spent: 10m 
      Work Description: jhsenjaliya commented on issue #2691: [GOBBLIN-830] launcher.type to job.launcher.type
URL: https://github.com/apache/incubator-gobblin/pull/2691#issuecomment-527246779
 
 
   @arjun4084346 , tried to handle both properties but its getting complex
   - {JobLauncherType} is nested, need to taken out, since most of the jobLauncher is defined in gobblin-runtime, it needs to be placed under that module.
   - instead of handling if/else at multiple place, I should add  {JobLauncherUtils.getJobLauncherType} method, but that would create circular dependency between gobblin-utility and gobblin-runtime.
   This is minor change compare to amount of refactoring that is required to support both properties which is basically touching the complexity of the project that requires proper refactoring ( [GIP2](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=119547565) ) 
   
   Any thoughts/comments ?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 305330)
    Time Spent: 40m  (was: 0.5h)

> update config key to define job launcher type
> ---------------------------------------------
>
>                 Key: GOBBLIN-830
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-830
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jay Sen
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> config key JOB_LAUNCHER_TYPE_KEY = "launcher.type" should be set to "job.launcher.type"



--
This message was sent by Atlassian Jira
(v8.3.2#803003)