You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/06 12:06:38 UTC

[GitHub] [maven-docck-plugin] timtebeek commented on pull request #1: [MDOCCK-35] - Upgrade Http Client

timtebeek commented on pull request #1:
URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-833469892


   Posted some comments in the issue, which might be best to repeat here to ensure they're seen before a merge:
   > Had to move HttpClient builder to execute method, as proxy setup was in execute.
   > Following redirects seems to be the default, hence no direct 1 to 1 replacement for that.
   > The only thing I couldn't work out a direct parallel for was preemptive authentication with the proxy.
   There might be some hints in here if that's still needed:
   https://github.com/apache/httpcomponents-client/blob/5.0.x/httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientPreemptiveBasicAuthentication.java
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org