[jira] [Comment Edited] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041664#comment-16041664 ] 

Ted Yu edited comment on FLINK-5488 at 6/14/17 1:00 PM:
--------------------------------------------------------

Please also fix the following in deployInternal() method:
{code}
    ClusterResourceDescription freeClusterMem = getCurrentFreeClusterResources(yarnClient);
{code}


was (Author: yuzhihong@gmail.com):
Please also fix the following in deployInternal():
{code}
    ClusterResourceDescription freeClusterMem = getCurrentFreeClusterResources(yarnClient);
{code}

> yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-5488
>                 URL: https://issues.apache.org/jira/browse/FLINK-5488
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>            Reporter: Ted Yu
>            Assignee: Fang Yong
>
> Here is one example:
> {code}
>     if(jobManagerMemoryMb > maxRes.getMemory() ) {
>       failSessionDuringDeployment(yarnClient, yarnApplication);
>       throw new YarnDeploymentException("The cluster does not have the requested resources for the JobManager available!\n"
>         + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " + jobManagerMemoryMb + "MB. " + NOTE);
>     }
> {code}
> yarnClient implements Closeable.
> It should be closed in situations where exception is thrown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)