You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/12/21 19:55:54 UTC

[GitHub] nifi pull request #2358: NIFI-4444: Ensuring the /nifi-api/controller redire...

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/2358

    NIFI-4444: Ensuring the /nifi-api/controller redirection filter runs

    NIFI-4444:
    - Ensure the /nifi-api/controller redirection filter executes before matching.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-4444

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2358
    
----
commit 230420507a2403d62c15c623762e92d95194ec7a
Author: Matt Gilman <ma...@...>
Date:   2017-12-21T19:54:09Z

    NIFI-4444:
    - Ensure the /nifi-api/controller redirection filter executes before matching.

----


---

[GitHub] nifi issue #2358: NIFI-4444: Ensuring the /nifi-api/controller redirection f...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2358
  
    Tested by visiting http://localhost:8080/nifi-api/controller without the patch applied -- error "The specified resource could not be found". With the patch applied -- returns expected JSON:
    
    `{"controller":{"id":"b76231af-0160-1000-11f3-3e937575391f","runningCount":0,"stoppedCount":0,"invalidCount":0,"disabledCount":0,"inputPortCount":0,"outputPortCount":0,"siteToSiteSecure":false,"instanceId":"b76231b1-0160-1000-9062-ebe2c82af742","inputPorts":[],"outputPorts":[]}}`
    
    Ran `contrib-check` and all tests pass. +1, merging. 


---

[GitHub] nifi issue #2358: NIFI-4444: Ensuring the /nifi-api/controller redirection f...

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/2358
  
    Thanks @alopresto! Closing...


---

[GitHub] nifi pull request #2358: NIFI-4444: Ensuring the /nifi-api/controller redire...

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman closed the pull request at:

    https://github.com/apache/nifi/pull/2358


---

[GitHub] nifi issue #2358: NIFI-4444: Ensuring the /nifi-api/controller redirection f...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2358
  
    @mcgilman there was a space in the magic incantation to close this PR. Please close it at your convenience. The merge commit is [10755e2](https://github.com/apache/nifi/commit/b7c9c88f9f786f9a84b0c1dc34026194010755e2). 


---

[GitHub] nifi issue #2358: NIFI-4444: Ensuring the /nifi-api/controller redirection f...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2358
  
    Reviewing...


---