You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by praveenmeenakshi56 <gi...@git.apache.org> on 2018/04/13 10:42:30 UTC
[GitHub] carbondata pull request #2170: [CARBONDATA-2346] Added fix for NULL error wh...
GitHub user praveenmeenakshi56 opened a pull request:
https://github.com/apache/carbondata/pull/2170
[CARBONDATA-2346] Added fix for NULL error while dropping partition with multiple Pre-Aggregate tables
Fixed null value issue for childcolumn
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NA
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
NA
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/praveenmeenakshi56/carbondata defect_part
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2170
----
commit dd3d3d1181847a1930048144740bfa053c878dd8
Author: praveenmeenakshi56 <pr...@...>
Date: 2018-04-13T10:31:35Z
Added fix for error while dropping partition with multiple Pre-Aggregate tables
----
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3782/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3784/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2170
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4447/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5000/
---
[GitHub] carbondata pull request #2170: [CARBONDATA-2346] Added fix for NULL error wh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2170
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5085/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2170
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4445/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3785/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4998/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3849/
---
[GitHub] carbondata pull request #2170: [CARBONDATA-2346] Added fix for NULL error wh...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2170#discussion_r181758974
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala ---
@@ -76,7 +76,8 @@ case class PreAggregateTableHelper(
val partitionerFields = fieldRelationMap.collect {
case (field, dataMapField) if parentPartitionColumns
.exists(parentCol =>
- parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&
+ dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&
--- End diff --
Please add comment
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3861/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5001/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2170
LGTM
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2170
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5070/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2170
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4443/
---
[GitHub] carbondata issue #2170: [CARBONDATA-2346] Added fix for NULL error while dro...
Posted by praveenmeenakshi56 <gi...@git.apache.org>.
Github user praveenmeenakshi56 commented on the issue:
https://github.com/apache/carbondata/pull/2170
retest this please
---