You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Nandor Kollar (JIRA)" <ji...@apache.org> on 2018/09/26 15:34:00 UTC

[jira] [Commented] (PARQUET-1425) [Format] Fix Thrift compiler warning

    [ https://issues.apache.org/jira/browse/PARQUET-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628950#comment-16628950 ] 

Nandor Kollar commented on PARQUET-1425:
----------------------------------------

[~wesmckinn] would you like this to be fixed in 2.6.0 format release, or is fine for you to get this done in a later release?

Currently parquet-format depends on 0.9.3 Thrift, and we also use this older version downstream. i8 was introduced in 0.10.0 (according to [Thrift Jira|https://issues.apache.org/jira/browse/THRIFT-3393]), and if we change byte to i8, 0.9.3 thrift compiler will fail.

> [Format] Fix Thrift compiler warning
> ------------------------------------
>
>                 Key: PARQUET-1425
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1425
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-format
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: format-2.6.0
>
>
> I see this warning frequently
> {code}
> [1/127] Running thrift compiler on parquet.thrift
> [WARNING:/home/wesm/code/arrow/cpp/src/parquet/parquet.thrift:295] The "byte" type is a compatibility alias for "i8". Use "i8" to emphasize the signedness of this type.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)