You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/06 15:01:24 UTC
[GitHub] [storm] bipinprasad opened a new pull request #3203: [STORM-3574]
Rebalance accepts config change affecting system component.
bipinprasad opened a new pull request #3203: [STORM-3574] Rebalance accepts config change affecting system component.
URL: https://github.com/apache/storm/pull/3203
Example when topology.metrics.consumer.register is specified to add metrics consumer.
Change rebalance() to start new tasks by calling computeExecutors and consequently
StormCommon.stormTaskInfo and StormCommon.systemTopology.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] bipinprasad commented on issue #3203: [STORM-3574]
Rebalance accepts config change affecting system component.
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on issue #3203: [STORM-3574] Rebalance accepts config change affecting system component.
URL: https://github.com/apache/storm/pull/3203#issuecomment-614796697
Resolved by STORM-3580
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on issue #3203: [STORM-3574] Rebalance
accepts config change affecting system component.
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on issue #3203: [STORM-3574] Rebalance accepts config change affecting system component.
URL: https://github.com/apache/storm/pull/3203#issuecomment-614952464
Why is it related to STORM-3580?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] bipinprasad closed pull request #3203: [STORM-3574]
Rebalance accepts config change affecting system component.
Posted by GitBox <gi...@apache.org>.
bipinprasad closed pull request #3203: [STORM-3574] Rebalance accepts config change affecting system component.
URL: https://github.com/apache/storm/pull/3203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on a change in pull request #3203:
[STORM-3574] Rebalance accepts config change affecting system component.
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3203: [STORM-3574] Rebalance accepts config change affecting system component.
URL: https://github.com/apache/storm/pull/3203#discussion_r378403905
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3346,6 +3346,12 @@ public void rebalance(String topoName, RebalanceOptions options)
if (subject != null) {
options.set_principal(subject.getPrincipals().iterator().next().getName());
}
+ String topoId = toTopoId(topoName);
+ StormTopology stormTopology = tryReadTopology(topoId, topoCache);
+ StormBase base = new StormBase();
+ base.set_name(topoName);
+ idToExecutors.getAndUpdate(new Assoc<>(topoId,
+ new HashSet<>(computeExecutors(topoId, base, topoConf, stormTopology))));
Review comment:
When rebalance happens,
the code here https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L1749 will remove the entry and let it recompute.
So I think we don't this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services