You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Satish Mittal <sa...@apache.org> on 2014/04/24 14:37:09 UTC
Re: Review Request 20553: OOZIE-1243: libtools dir should not include hadoop
JARs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20553/
-----------------------------------------------------------
(Updated April 24, 2014, 12:37 p.m.)
Review request for oozie and Alejandro Abdelnur.
Repository: oozie-git
Description
-------
All the setup tools should consume the hadoop JARs from the libext/ directory, having them in the libtools/ dir make things fail when using different hadoop versions other than the one used to compile Oozie.
Diffs
-----
src/main/assemblies/tools.xml 9b65773
tools/pom.xml 1245e47
Diff: https://reviews.apache.org/r/20553/diff/
Testing
-------
- Prepared distro and ran the following command: 'oozie-setup.sh sharelib create'. Started oozie successfully.
Thanks,
Satish Mittal
Re: Review Request 20553: OOZIE-1243: libtools dir should not include hadoop
JARs
Posted by Satish Mittal <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20553/
-----------------------------------------------------------
(Updated April 28, 2014, 12:53 p.m.)
Review request for oozie and Alejandro Abdelnur.
Changes
-------
Added comment in src/main/assemblies/tools.xml
Bugs: OOZIE-1243
https://issues.apache.org/jira/browse/OOZIE-1243
Repository: oozie-git
Description
-------
All the setup tools should consume the hadoop JARs from the libext/ directory, having them in the libtools/ dir make things fail when using different hadoop versions other than the one used to compile Oozie.
Diffs (updated)
-----
src/main/assemblies/tools.xml 9b65773
tools/pom.xml 1245e47
Diff: https://reviews.apache.org/r/20553/diff/
Testing
-------
- Prepared distro and ran the following command: 'oozie-setup.sh sharelib create'. Started oozie successfully.
Thanks,
Satish Mittal
Re: Review Request 20553: OOZIE-1243: libtools dir should not include hadoop
JARs
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20553/#review41590
-----------------------------------------------------------
Ship it!
Ship It!
- shwethags
On April 28, 2014, 12:12 p.m., Satish Mittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20553/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 12:12 p.m.)
>
>
> Review request for oozie and Alejandro Abdelnur.
>
>
> Bugs: OOZIE-1243
> https://issues.apache.org/jira/browse/OOZIE-1243
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> All the setup tools should consume the hadoop JARs from the libext/ directory, having them in the libtools/ dir make things fail when using different hadoop versions other than the one used to compile Oozie.
>
>
> Diffs
> -----
>
> src/main/assemblies/tools.xml 9b65773
> tools/pom.xml 1245e47
>
> Diff: https://reviews.apache.org/r/20553/diff/
>
>
> Testing
> -------
>
> - Prepared distro and ran the following command: 'oozie-setup.sh sharelib create'. Started oozie successfully.
>
>
> Thanks,
>
> Satish Mittal
>
>
Re: Review Request 20553: OOZIE-1243: libtools dir should not include hadoop
JARs
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20553/#review41589
-----------------------------------------------------------
src/main/assemblies/tools.xml
<https://reviews.apache.org/r/20553/#comment75122>
can you add a comment on why its runtime. Its not intuitive. Looks good otherwise
- shwethags
On April 28, 2014, 12:12 p.m., Satish Mittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20553/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 12:12 p.m.)
>
>
> Review request for oozie and Alejandro Abdelnur.
>
>
> Bugs: OOZIE-1243
> https://issues.apache.org/jira/browse/OOZIE-1243
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> All the setup tools should consume the hadoop JARs from the libext/ directory, having them in the libtools/ dir make things fail when using different hadoop versions other than the one used to compile Oozie.
>
>
> Diffs
> -----
>
> src/main/assemblies/tools.xml 9b65773
> tools/pom.xml 1245e47
>
> Diff: https://reviews.apache.org/r/20553/diff/
>
>
> Testing
> -------
>
> - Prepared distro and ran the following command: 'oozie-setup.sh sharelib create'. Started oozie successfully.
>
>
> Thanks,
>
> Satish Mittal
>
>
Re: Review Request 20553: OOZIE-1243: libtools dir should not include hadoop
JARs
Posted by Satish Mittal <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20553/
-----------------------------------------------------------
(Updated April 28, 2014, 12:12 p.m.)
Review request for oozie and Alejandro Abdelnur.
Changes
-------
Attached updated patch that makes org.apache.oozie:oozie-hadoop dependency in tools/pom.xml as provided, and sets scope in src/main/assemblies/tools.xml as runtime (which assembles compile and runtime, but skips provided scope).
Bugs: OOZIE-1243
https://issues.apache.org/jira/browse/OOZIE-1243
Repository: oozie-git
Description
-------
All the setup tools should consume the hadoop JARs from the libext/ directory, having them in the libtools/ dir make things fail when using different hadoop versions other than the one used to compile Oozie.
Diffs (updated)
-----
src/main/assemblies/tools.xml 9b65773
tools/pom.xml 1245e47
Diff: https://reviews.apache.org/r/20553/diff/
Testing
-------
- Prepared distro and ran the following command: 'oozie-setup.sh sharelib create'. Started oozie successfully.
Thanks,
Satish Mittal
Re: Review Request 20553: OOZIE-1243: libtools dir should not include hadoop
JARs
Posted by Satish Mittal <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20553/
-----------------------------------------------------------
(Updated April 24, 2014, 1:01 p.m.)
Review request for oozie and Alejandro Abdelnur.
Bugs: OOZIE-1243
https://issues.apache.org/jira/browse/OOZIE-1243
Repository: oozie-git
Description
-------
All the setup tools should consume the hadoop JARs from the libext/ directory, having them in the libtools/ dir make things fail when using different hadoop versions other than the one used to compile Oozie.
Diffs
-----
src/main/assemblies/tools.xml 9b65773
tools/pom.xml 1245e47
Diff: https://reviews.apache.org/r/20553/diff/
Testing
-------
- Prepared distro and ran the following command: 'oozie-setup.sh sharelib create'. Started oozie successfully.
Thanks,
Satish Mittal