You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Boglarka Egyed <eg...@gmail.com> on 2016/07/01 09:31:22 UTC

Re: Review Request 49192: OraOop does not close connections properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49192/#review140326
-----------------------------------------------------------


Ship it!




Ship It!

- Boglarka Egyed


On June 30, 2016, 6:39 a.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49192/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 6:39 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2971
>     https://issues.apache.org/jira/browse/SQOOP-2971
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Connections are now closed properly in OraOopDataDrivenDBInputFormat class.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormat.java 13f05d5 
>   src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 3a8e5d0 
>   src/test/com/cloudera/sqoop/ThirdPartyTests.java 50f3192 
>   src/test/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormatConnectionCloseTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49192/diff/
> 
> 
> Testing
> -------
> 
> We have started an import job on a cluster with a patched Sqoop version and we have verified that 1 map task now uses only 1 Oracle connection.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>