You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:15:19 UTC

[GitHub] [iceberg] RussellSpitzer commented on issue #2435: RepairManifestsAction

RussellSpitzer commented on issue #2435:
URL: https://github.com/apache/iceberg/issues/2435#issuecomment-814998102


   The last one there "removeDeletedFiles" is the most dangerous imho, but I think this is a pretty good setup. 
   
   Although with the new Action API it probably just makes sense to have all the "withX" as "options" defaulted to true except for removeDeletedFiles. I'm also not sure if fixing rowcount and metrics seperately really needs to be a thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org