[jira] [Comment Edited] (GROOVY-9089) STC: owner qualifier produces error for nested closures

["Eric Milles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831182#comment-16831182 ] 

Eric Milles edited comment on GROOVY-9089 at 5/1/19 7:00 PM:
-------------------------------------------------------------

Before doing any of that, this bit in {{StaticTypeCheckingVisitor.visitVariableExpression}} is not setup for nested closures:
{code:java}
        TypeCheckingContext.EnclosingClosure enclosingClosure = typeCheckingContext.getEnclosingClosure();
        if (enclosingClosure != null) {
            String name = vexp.getName();
            if (name.equals("owner") || name.equals("thisObject")) {
                storeType(vexp, typeCheckingContext.getEnclosingClassNode());
                return;
            } else if ("delegate".equals(name)) {
                DelegationMetadata md = getDelegationMetadata(enclosingClosure.getClosureExpression());
                ClassNode type = typeCheckingContext.getEnclosingClassNode();
                if (md != null) type = md.getType();
                storeType(vexp, type);
                return;
            }
        }
{code}

Here is my thought:
{code:java}
        TypeCheckingContext.EnclosingClosure enclosingClosure = typeCheckingContext.getEnclosingClosure();
        if (enclosingClosure != null) {
            /* GRECLIPSE edit -- GROOVY-9089
            String name = vexp.getName();
            if (name.equals("owner") || name.equals("thisObject")) {
                storeType(vexp, typeCheckingContext.getEnclosingClassNode());
                return;
            } else if ("delegate".equals(name)) {
                DelegationMetadata md = getDelegationMetadata(enclosingClosure.getClosureExpression());
                ClassNode type = typeCheckingContext.getEnclosingClassNode();
                if (md != null) type = md.getType();
                storeType(vexp, type);
                return;
            }
            */
            switch (vexp.getName()) {
            case "delegate":
                DelegationMetadata md = getDelegationMetadata(enclosingClosure.getClosureExpression());
                if (md != null) {
                    storeType(vexp, md.getType());
                    return;
                }
                // falls through
            case "owner":
                if (typeCheckingContext.getEnclosingClosureStack().size() > 1) {
                    storeType(vexp, CLOSURE_TYPE); // Can this be more specific?
                    return;
                }
                // falls through
            case "thisObject":
                storeType(vexp, typeCheckingContext.getEnclosingClassNode());
                return;
            }
            // GRECLIPSE end
        }
{code}


was (Author: emilles):
Before doing any of that, this bit in {{StaticTypeCheckingVisitor.visitVariableExpression}} is not setup for nested closures:
{code:java}
        TypeCheckingContext.EnclosingClosure enclosingClosure = typeCheckingContext.getEnclosingClosure();
        if (enclosingClosure != null) {
            String name = vexp.getName();
            if (name.equals("owner") || name.equals("thisObject")) {
                storeType(vexp, typeCheckingContext.getEnclosingClassNode());
                return;
            } else if ("delegate".equals(name)) {
                DelegationMetadata md = getDelegationMetadata(enclosingClosure.getClosureExpression());
                ClassNode type = typeCheckingContext.getEnclosingClassNode();
                if (md != null) type = md.getType();
                storeType(vexp, type);
                return;
            }
        }
{code}

> STC: owner qualifier produces error for nested closures
> -------------------------------------------------------
>
>                 Key: GROOVY-9089
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9089
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha-4, 2.5.6
>            Reporter: Eric Milles
>            Priority: Major
>
> In the example script below, the use of the "owner" qualifier causes an error.  Replace with "delegate" and no error.  Disable static compilation and no error.
> {code:groovy}
> class C1 {
>   void m() {
>     print 'outer delegate'
>   }
> }
> class C2 {
>   void m() {
>     print 'inner delegate'
>   }
> }
> void outer(@DelegatesTo(value = C1) Closure block) {
>   block.delegate = new C1()
>   block()
> }
> void inner(@DelegatesTo(value = C2, strategy = Closure.DELEGATE_FIRST) Closure block) {
>   block.delegate = new C2()
>   block()
> }
> @groovy.transform.CompileStatic // comment out and script prints "outer delegate" as expected
> void test() {
>   outer {
>     inner {
>       owner.m() // "Cannot find matching method Script#m(). Please check if the declared type is right and if the method exists."
>       // replace "owner" with "delegate" and CompileStatic has no error and prints "inner delegate" as expected
>     }
>   }
> }
> test()
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)