[GitHub] [flink] echauchot commented on a change in pull request #14510: [FLINK-19656] [metrics] filter delimiter in metrics components

[GitBox <gi...@apache.org>]

echauchot commented on a change in pull request #14510:
URL: https://github.com/apache/flink/pull/14510#discussion_r554933840



##########
File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/MetricGroup.java
##########
@@ -186,6 +186,15 @@
      */
     Map<String, String> getAllVariables();
 
+    /**
+     * Returns a map of all variables and their associated value, for example {@code
+     * {"<host>"="host-7", "<tm_id>"="taskmanager-2"}}.
+     *
+     * @param filter character filter which is applied to the variables and values if not null.
+     * @return map of all variables and their associated value
+     */
+    Map<String, String> getAllVariables(CharacterFilter filter);

Review comment:
       Yes, I hesitated on that one. Ok I'll revert the interface extension and related changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org