You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "KyleBoyer (via GitHub)" <gi...@apache.org> on 2024/12/02 18:37:10 UTC
[PR] Add unexpected-response handler to gremlin-javascript connection websocket [tinkerpop]
KyleBoyer opened a new pull request, #2935:
URL: https://github.com/apache/tinkerpop/pull/2935
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.7-dev -> 3.7.4 (non-breaking)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
This PR helps provide more information to the end user when a websocket `unexpected-response` is encountered. This is particularly helpful for using AWS Neptune, which sometimes encounters an "unexpected-response" status code, with a body describing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unexpected-response handler to gremlin-javascript connection websocket [tinkerpop]
Posted by "KyleBoyer (via GitHub)" <gi...@apache.org>.
KyleBoyer commented on PR #2935:
URL: https://github.com/apache/tinkerpop/pull/2935#issuecomment-2513428310
New PR targeting the correct base branch opened here: https://github.com/apache/tinkerpop/pull/2936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unexpected-response handler to gremlin-javascript connection websocket [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2935:
URL: https://github.com/apache/tinkerpop/pull/2935#issuecomment-2513167104
Hi and thank you for contributing.
The `master` branch which is for 4.0 won't support WebSockets so your changes will need to target 3.7-dev instead. The code you are modifying now will be replaced with code that supports HTTP.
Have you noticed the same `unexpected-response` coming back from Gremlin Server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unexpected-response handler to gremlin-javascript connection websocket [tinkerpop]
Posted by "KyleBoyer (via GitHub)" <gi...@apache.org>.
KyleBoyer commented on PR #2935:
URL: https://github.com/apache/tinkerpop/pull/2935#issuecomment-2513359895
Sounds good, I'll open a new PR to target the correct branch and close this PR. We have noticed unexpected responses for 3 different situations on AWS Neptune so far. One was a random 400 error status code bug that AWS fixed. Another situation with AWS Neptune was using invalid AWS credentials. Third one we noticed recently is a throttling 500 status code. These situations were difficult to debug before we started reading the body when the web socket hit these unexpected responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add unexpected-response handler to gremlin-javascript connection websocket [tinkerpop]
Posted by "KyleBoyer (via GitHub)" <gi...@apache.org>.
KyleBoyer closed pull request #2935: Add unexpected-response handler to gremlin-javascript connection websocket
URL: https://github.com/apache/tinkerpop/pull/2935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org