[GitHub] nifi pull request #571: NIFI-2208 - Support Custom Properties in Expression ...

[JPercivall <gi...@git.apache.org>]

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/571#discussion_r72111965
  
    --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/VariableRegistryUtils.java ---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.nifi.flowfile.FlowFile;
    +
    +public class VariableRegistryUtils {
    +
    +
    +    public static VariableRegistry createVariableRegistry(){
    +        VariableRegistry variableRegistry = VariableRegistryFactory.getInstance();
    +        VariableRegistry envRegistry = VariableRegistryFactory.getInstance(System.getenv());
    +        VariableRegistry propRegistry = VariableRegistryFactory.getPropertiesInstance(System.getProperties());
    +        variableRegistry.addRegistry(envRegistry);
    +        variableRegistry.addRegistry(propRegistry);
    +        return variableRegistry;
    +    }
    +
    +    public static VariableRegistry populateRegistry(VariableRegistry variableRegistry, final FlowFile flowFile, final Map<String, String> additionalAttributes){
    --- End diff --
    
    This should be renamed to reflect that it is creating a new instance of a VariableRegistry (line 48) and then copying the values from the passed VariableRegistry and additionalAttributes into that new instance.
    
    From looking at the method name and parameters, one would expect the passed variableRegistry to be populated with the passed additionalAttributes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---