You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by GitBox <gi...@apache.org> on 2019/05/16 02:13:51 UTC
[GitHub] [trafodion] sandhyasun commented on a change in pull request #1840:
[TRAFODION-3308] Improve error reporting when a process cannot be started
sandhyasun commented on a change in pull request #1840: [TRAFODION-3308] Improve error reporting when a process cannot be started
URL: https://github.com/apache/trafodion/pull/1840#discussion_r284512969
##########
File path: core/sql/cli/ExSqlComp.cpp
##########
@@ -172,7 +172,8 @@ ExSqlComp::ReturnStatus ExSqlComp::createServer()
//
if (ret == ERROR)
{
- error(arkcmpErrorServer);
+ if ((!diagArea_->contains(-2013)) && (!diagArea_->contains(-2012))) // avoid generating redundant error
+ error(arkcmpErrorServer);
Review comment:
2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services