[GitHub] [hbase] virajjasani commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1879:
URL: https://github.com/apache/hbase/pull/1879#discussion_r438262193



##########
File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
##########
@@ -294,7 +294,7 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
                 </tr>
                 <tr>
                     <td>ZooKeeper Client Version</td>
-                    <td><% org.apache.zookeeper.Version.getVersion() %>, revision=<% org.apache.zookeeper.Version.getRevision() %></td>
+                    <td><% org.apache.zookeeper.Version.getVersion() %></td>

Review comment:
       Agree, no need of revision IMHO

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -1811,9 +1811,10 @@ private static Op toZooKeeperOp(ZooKeeperWatcher zkw, ZKUtilOp op)
    */
   public static void multiOrSequential(ZooKeeperWatcher zkw, List<ZKUtilOp> ops,
       boolean runSequentialOnMultiFailure) throws KeeperException {
-    if (ops == null) return;
+    if (ops == null || ops.isEmpty()) {

Review comment:
       Did our unit tests catch this one or you knew it already? I just want to know what preparation we should do while upgrading ZK or any other heavy dependency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org