You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/09/18 16:33:49 UTC
[GitHub] [hudi] yihua commented on a diff in pull request #9331: [HUDI-6623] Move the sorting of HoodieMetaserverClient instants from …
yihua commented on code in PR #9331:
URL: https://github.com/apache/hudi/pull/9331#discussion_r1328990836
##########
hudi-platform-service/hudi-metaserver/hudi-metaserver-client/src/main/java/org/apache/hudi/metaserver/client/HoodieMetaserverClientImp.java:
##########
@@ -109,7 +110,7 @@ public void createTable(Table table) {
@Override
public List<HoodieInstant> listInstants(String db, String tb, int commitNum) {
return exceptionWrapper(() -> this.client.listInstants(db, tb, commitNum).stream()
- .map(EntityConversions::fromTHoodieInstant)
+ .map(EntityConversions::fromTHoodieInstant).sorted(Comparator.comparing(HoodieInstant::getTimestamp))
Review Comment:
Should this be reversely sorted based on the server side logic (`ORDER BY ts DESC`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org