You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by attilapiros <gi...@git.apache.org> on 2018/11/30 12:57:42 UTC
[GitHub] spark pull request #23188: [SPARK-26232][Build] Remove unused dependency to ...
GitHub user attilapiros opened a pull request:
https://github.com/apache/spark/pull/23188
[SPARK-26232][Build] Remove unused dependency to Netty3
## What changes were proposed in this pull request?
Removing dependency to Netty3 as it is unused.
The reason it is not collide with Netty4 is they are using different package names:
Netty3: org.jboss.netty.*
Netty4: io.netty.*
## How was this patch tested?
Maven build.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/attilapiros/spark SPARK-26232
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23188
----
commit 42509fad4a51a4ab32ae73702e41e7f56bf5cbad
Author: “attilapiros” <pi...@...>
Date: 2018-11-30T12:52:36Z
Remove unneded Netty3 dependency
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23188
**[Test build #99512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99512/testReport)** for PR 23188 at commit [`42509fa`](https://github.com/apache/spark/commit/42509fad4a51a4ab32ae73702e41e7f56bf5cbad).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/23188
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/23188
Jenkins, retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23188
**[Test build #99512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99512/testReport)** for PR 23188 at commit [`42509fa`](https://github.com/apache/spark/commit/42509fad4a51a4ab32ae73702e41e7f56bf5cbad).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build] Remove unused dependency to Netty3
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23188
**[Test build #99511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99511/testReport)** for PR 23188 at commit [`42509fa`](https://github.com/apache/spark/commit/42509fad4a51a4ab32ae73702e41e7f56bf5cbad).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23188: [SPARK-26232][Build][test-maven] Remove unused de...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros closed the pull request at:
https://github.com/apache/spark/pull/23188
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build] Remove unused dependency to Netty3
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23188
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build] Remove unused dependency to Netty3
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23188
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build] Remove unused dependency to Netty3
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23188
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99511/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23188
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99512/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23188
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build][test-maven] Remove unused dependenc...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/23188
I am closing this issue as I see one of the third party tool uses Netty3. So as a transitive dependency Netty3 is really needed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build] Remove unused dependency to Netty3
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23188
**[Test build #99511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99511/testReport)** for PR 23188 at commit [`42509fa`](https://github.com/apache/spark/commit/42509fad4a51a4ab32ae73702e41e7f56bf5cbad).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23188: [SPARK-26232][Build] Remove unused dependency to Netty3
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23188
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org