You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/11/03 10:44:42 UTC
[GitHub] [zookeeper] 2k0ri opened a new pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
2k0ri opened a new pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674
clientPort in zoo.cfg is forcefully complemented from client address by QuorumPeerConfig#setupClientPort even though secureClientPort is set and matches with client address' port.
Because of this behavior, in case rolling update with replacing clientPort to secureClientPort in the same port number following [Upgrading existing non-TLS cluster with no downtime](https://zookeeper.apache.org/doc/r3.7.0/zookeeperAdmin.html#Upgrading+existing+nonTLS+cluster) conflicts and gets errors below.
```
2021-03-29 23:21:58,638 - INFO [main:NettyServerCnxnFactory@590] - binding to port /0.0.0.0:2181
2021-03-29 23:21:58,748 - INFO [main:NettyServerCnxnFactory@595] - bound to port 2181
2021-03-29 23:21:58,749 - INFO [main:NettyServerCnxnFactory@590] - binding to port 0.0.0.0/0.0.0.0:2181
2021-03-29 23:21:58,753 - ERROR [main:QuorumPeerMain@101] - Unexpected exception, exiting abnormally
java.net.BindException: Address already in use
```
This PR makes clientPort complement by QuorumPeerConfig#setupClientPort only when both clientPort and secureClientPort are empty, and allow serving zookeeper server only with secure client port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] 2k0ri edited a comment on pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
Posted by GitBox <gi...@apache.org>.
2k0ri edited a comment on pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674#issuecomment-820888107
@eolivelli Thank you for your review.
Is there anything else that I should do before merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] 2k0ri commented on pull request #1674: ZOOKEEPER-4276: Support setupQuorumPeerConfig only with secureClientPort
Posted by GitBox <gi...@apache.org>.
2k0ri commented on pull request #1674:
URL: https://github.com/apache/zookeeper/pull/1674#issuecomment-820888107
@eolivelli Thank you for your review.
Is there anything else that I should do until merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org