You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/30 23:02:11 UTC
[GitHub] [maven-surefire] andpab opened a new pull request, #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support
andpab opened a new pull request, #591:
URL: https://github.com/apache/maven-surefire/pull/591
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #591:
URL: https://github.com/apache/maven-surefire/pull/591#issuecomment-1368237994
Well, it's good I did that, because silly me forgot to add the import scope to the asm-bom dependency at first.
Now we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #591:
URL: https://github.com/apache/maven-surefire/pull/591#issuecomment-1368206317
> We could/should change to use the asm bom.
Done.
I've also added a commit to replace JDK18 which is EOL by now with JDK19 in the builds, partly to demonstrate that it works with the changes I made. If that build-related change shouldn't be part of this PR, then let me know and I'll drop it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #591:
URL: https://github.com/apache/maven-surefire/pull/591#issuecomment-1368568197
Thankfully, @slachiewicz has just released a new version of plexus-java which brings asm 9.4. So I'm going to simplify the pull request and just update the `plexus-java.version` property to 1.1.2 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #591: [SUREFIRE-2139] Raise plexus-java to 1.1.2 for proper Java 19/20 bytecode support
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #591:
URL: https://github.com/apache/maven-surefire/pull/591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org