You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by lu...@apache.org on 2024/10/02 12:37:57 UTC

(kafka) branch kip1071 updated: KAFKA-17125: finalize TaskId (#17300)

This is an automated email from the ASF dual-hosted git repository.

lucasbru pushed a commit to branch kip1071
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/kip1071 by this push:
     new a8d0839b4c8 KAFKA-17125: finalize TaskId (#17300)
a8d0839b4c8 is described below

commit a8d0839b4c8bbfab8041ea965074ca0b04c3db53
Author: Alieh Saeedi <10...@users.noreply.github.com>
AuthorDate: Wed Oct 2 14:37:49 2024 +0200

    KAFKA-17125: finalize TaskId (#17300)
---
 .../org/apache/kafka/coordinator/group/taskassignor/TaskId.java  | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/taskassignor/TaskId.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/taskassignor/TaskId.java
index 885858f700d..8991aeb11ca 100644
--- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/taskassignor/TaskId.java
+++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/taskassignor/TaskId.java
@@ -18,12 +18,13 @@ package org.apache.kafka.coordinator.group.taskassignor;
 
 import java.util.Objects;
 
-public final class TaskId {
+public final class TaskId implements Comparable<TaskId> {
 
     private final String subtopologyId;
     private final int partition;
 
     public TaskId(final String subtopologyId, final int partition) {
+        Objects.requireNonNull(subtopologyId);
         this.subtopologyId = subtopologyId;
         this.partition = partition;
     }
@@ -65,6 +66,10 @@ public final class TaskId {
     }
 
     public int compareTo(final TaskId other) {
-        return this.hashCode() - other.hashCode();
+        int diff = subtopologyId.compareTo(other.subtopologyId);
+        if (diff == 0) {
+            diff = partition - other.partition;
+        }
+        return diff;
     }
 }