You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "ahelmihudhud (via GitHub)" <gi...@apache.org> on 2025/11/19 22:16:23 UTC

[I] virtual_hosted_style_request bad calculation [datafusion-comet]

ahelmihudhud opened a new issue, #2802:
URL: https://github.com/apache/datafusion-comet/issues/2802

   ### Describe the bug
   
   while setting the connection to S3 in (native/core/src/parquet/objectstore/s3.rs)
   a mistake is being made in calculating `virtual_hosted_style_request` 
   which causes the connection to use a combination of path style and virtual hosted style.
   
   `        virtual_hosted_style_request = path_style.to_lowercase() == "true";
   `
   
   `
       if virtual_hosted_style_request {
           if endpoint.ends_with("/") {
               Some(format!("{endpoint}{bucket}"))
           } else {
               Some(format!("{endpoint}/{bucket}"))
           }
       } else {
           Some(endpoint) // Avoid extra to_string() call since endpoint is already a String
       }
   `
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] virtual_hosted_style_request bad calculation [datafusion-comet]

Posted by "dwsmith1983 (via GitHub)" <gi...@apache.org>.
dwsmith1983 commented on issue #2802:
URL: https://github.com/apache/datafusion-comet/issues/2802#issuecomment-6066187996

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org