[GitHub] [hudi] xushiyan commented on a diff in pull request #9045: [HUDI-6432] Fix TestCleanPlanExecutor

["xushiyan (via GitHub)" <gi...@apache.org>]

xushiyan commented on code in PR #9045:
URL: https://github.com/apache/hudi/pull/9045#discussion_r1240926935


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -827,32 +715,6 @@ private static void assertCleanMetadataPathEquals(Map<String, Tuple3> expected,
     }
   }
 
-  /**
-   * Generate Bootstrap index, bootstrap base file and corresponding metaClient.
-   *
-   * @return Partition to BootstrapFileMapping Map
-   * @throws IOException
-   */
-  protected Map<String, List<BootstrapFileMapping>> generateBootstrapIndexAndSourceData(String... partitions) throws IOException {

Review Comment:
   moved up; no change in logic



##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -1327,19 +1151,4 @@ private Stream<Pair<String, String>> convertPathToFileIdWithCommitTime(final Hoo
     return Stream.concat(stream1, stream2);
   }
 
-  protected static HoodieCommitMetadata generateCommitMetadata(

Review Comment:
   moved up; no change in logic



##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -1128,44 +990,6 @@ public void testIncrementalFallbackToFullClean() throws Exception {
     assertTrue(testTable.baseFileExists(p2, "4", file4P2), "Latest FileSlice exists");
   }
 
-  public void commitWithMdt(String instantTime, Map<String, List<String>> partToFileId,
-                            HoodieTestTable testTable, HoodieTableMetadataWriter metadataWriter) throws Exception {
-    commitWithMdt(instantTime, partToFileId, testTable, metadataWriter, true, false);
-  }
-
-  public void commitWithMdt(String instantTime, Map<String, List<String>> partToFileId,

Review Comment:
   moved up; no change in logic



##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -404,110 +396,6 @@ private void testFailedInsertAndCleanByCommits(
     assertEquals(3, rollbackMetadata.getTotalFilesDeleted());
   }
 
-  /**
-   * Helper to run cleaner and collect Clean Stats.
-   *
-   * @param config HoodieWriteConfig
-   */
-  protected List<HoodieCleanStat> runCleaner(HoodieWriteConfig config) throws IOException {
-    return runCleaner(config, false, false, 1, false);
-  }
-
-  protected List<HoodieCleanStat> runCleanerWithInstantFormat(HoodieWriteConfig config, boolean needInstantInHudiFormat) throws IOException {
-    return runCleaner(config, false, false, 1, needInstantInHudiFormat);
-  }
-
-  protected List<HoodieCleanStat> runCleaner(HoodieWriteConfig config, int firstCommitSequence, boolean needInstantInHudiFormat) throws IOException {
-    return runCleaner(config, false, false, firstCommitSequence, needInstantInHudiFormat);
-  }
-
-  protected List<HoodieCleanStat> runCleaner(HoodieWriteConfig config, boolean simulateRetryFailure) throws IOException {
-    return runCleaner(config, simulateRetryFailure, false, 1, false);
-  }
-
-  protected List<HoodieCleanStat> runCleaner(
-      HoodieWriteConfig config, boolean simulateRetryFailure, boolean simulateMetadataFailure) throws IOException {
-    return runCleaner(config, simulateRetryFailure, simulateMetadataFailure, 1, false);
-  }
-
-  /**
-   * Helper to run cleaner and collect Clean Stats.
-   *
-   * @param config HoodieWriteConfig
-   */
-  protected List<HoodieCleanStat> runCleaner(

Review Comment:
   moved up; no change in logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org