You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/31 23:25:51 UTC
[jira] [Commented] (BEAM-1365) Bigquery dataset names should allow
for . inside them
[ https://issues.apache.org/jira/browse/BEAM-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847706#comment-15847706 ]
ASF GitHub Bot commented on BEAM-1365:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1886
[BEAM-1365] Fix the big query regex to account for . in dataset name
R: @chamikaramj PTAL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/incubator-beam BEAM-fix-bigquery-lint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1886
----
commit 2c7fffa67ba96506879dde5ad14663486f28897d
Author: Sourabh Bajaj <so...@google.com>
Date: 2017-01-31T23:18:39Z
Fix the big query regex to account for . in dataset name
----
> Bigquery dataset names should allow for . inside them
> -----------------------------------------------------
>
> Key: BEAM-1365
> URL: https://issues.apache.org/jira/browse/BEAM-1365
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Sourabh Bajaj
> Assignee: Sourabh Bajaj
> Priority: Minor
>
> Bigquery datasets allow for . inside them but the regex in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/bigquery.py#L305 doesn't allow for this.
> Change the regex to r'^((?P<project>.+):)?(?P<dataset>[\w\.]+)\.(?P<table>[\w\$]+)$', table)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)