You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2011/08/29 19:50:38 UTC

[jira] [Created] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Prefer mvn test -DskipTests over mvn compile in test-patch.sh
-------------------------------------------------------------

                 Key: HADOOP-7589
                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
             Project: Hadoop Common
          Issue Type: Bug
          Components: build
    Affects Versions: 0.23.0, 0.24.0
            Reporter: Robert Joseph Evans
            Assignee: Robert Joseph Evans
             Fix For: 0.23.0, 0.24.0


I got a failure running test-patch with a clean .m2 directory.

To quote Alejandro:
{bq}
The reason for this failure is because of how Maven reactor/dependency
resolution works (IMO a bug).

Maven reactor/dependency resolution is smart enough to create the classpath
using the classes from all modules being built.

However, this smartness falls short just a bit. The dependencies are
resolved using the deepest maven phase used by current mvn invocation. If
you are doing 'mvn compile' you don't get to the test compile phase.  This
means that the TEST classes are not resolved from the build but from the
cache/repo.

The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
will include the TEST classes from the build.
{bq}

So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093071#comment-13093071 ] 

Hudson commented on HADOOP-7589:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #812 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/812/])
    HADOOP-7589. Prefer mvn test -DskipTests over mvn compile in test-patch.sh (Robert Evans via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162928
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh


> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-7589:
----------------------------------------

    Description: 
I got a failure running test-patch with a clean .m2 directory.

To quote Alejandro:
{quote}
The reason for this failure is because of how Maven reactor/dependency
resolution works (IMO a bug).

Maven reactor/dependency resolution is smart enough to create the classpath
using the classes from all modules being built.

However, this smartness falls short just a bit. The dependencies are
resolved using the deepest maven phase used by current mvn invocation. If
you are doing 'mvn compile' you don't get to the test compile phase.  This
means that the TEST classes are not resolved from the build but from the
cache/repo.

The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
will include the TEST classes from the build.
{quote}

So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

  was:
I got a failure running test-patch with a clean .m2 directory.

To quote Alejandro:
{bq}
The reason for this failure is because of how Maven reactor/dependency
resolution works (IMO a bug).

Maven reactor/dependency resolution is smart enough to create the classpath
using the classes from all modules being built.

However, this smartness falls short just a bit. The dependencies are
resolved using the deepest maven phase used by current mvn invocation. If
you are doing 'mvn compile' you don't get to the test compile phase.  This
means that the TEST classes are not resolved from the build but from the
cache/repo.

The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
will include the TEST classes from the build.
{bq}

So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests


> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-7589:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just pushed this. Thanks Bobby!

> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093061#comment-13093061 ] 

Hudson commented on HADOOP-7589:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #802 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/802/])
    HADOOP-7589. Prefer mvn test -DskipTests over mvn compile in test-patch.sh (Robert Evans via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162928
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh


> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-7589:
----------------------------------------

    Attachment: HADOOP-7589-V1.patch

Quick patch to replace compile with test -DskipTests 

> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093030#comment-13093030 ] 

Scott Carey commented on HADOOP-7589:
-------------------------------------

Doesn't using 'mvn test-compile' the same as 'mvn test -DskipTests' ?

> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093064#comment-13093064 ] 

Hudson commented on HADOOP-7589:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #879 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/879/])
    HADOOP-7589. Prefer mvn test -DskipTests over mvn compile in test-patch.sh (Robert Evans via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162928
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh


> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093798#comment-13093798 ] 

Hudson commented on HADOOP-7589:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #801 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/801/])
    HADOOP-7589. Prefer mvn test -DskipTests over mvn compile in test-patch.sh (Robert Evans via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162928
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh


> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093692#comment-13093692 ] 

Hudson commented on HADOOP-7589:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #776 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/776/])
    HADOOP-7589. Prefer mvn test -DskipTests over mvn compile in test-patch.sh (Robert Evans via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162928
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh


> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093026#comment-13093026 ] 

Hadoop QA commented on HADOOP-7589:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12492106/HADOOP-7589-V1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/95//console

This message is automatically generated.

> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093032#comment-13093032 ] 

Alejandro Abdelnur commented on HADOOP-7589:
--------------------------------------------

It looks good.

> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7589) Prefer mvn test -DskipTests over mvn compile in test-patch.sh

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-7589:
----------------------------------------

    Status: Patch Available  (was: Open)

This patch should apply to both trunk and 0.23.0 with no changes.

> Prefer mvn test -DskipTests over mvn compile in test-patch.sh
> -------------------------------------------------------------
>
>                 Key: HADOOP-7589
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7589
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7589-V1.patch
>
>
> I got a failure running test-patch with a clean .m2 directory.
> To quote Alejandro:
> {quote}
> The reason for this failure is because of how Maven reactor/dependency
> resolution works (IMO a bug).
> Maven reactor/dependency resolution is smart enough to create the classpath
> using the classes from all modules being built.
> However, this smartness falls short just a bit. The dependencies are
> resolved using the deepest maven phase used by current mvn invocation. If
> you are doing 'mvn compile' you don't get to the test compile phase.  This
> means that the TEST classes are not resolved from the build but from the
> cache/repo.
> The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
> will include the TEST classes from the build.
> {quote}
> So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira