You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/02/01 09:04:52 UTC

[GitHub] spark pull request #20455: [SPARK-23284][SQL] Document the behavior of sever...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20455#discussion_r165292391
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala ---
    @@ -1261,4 +1261,140 @@ class ColumnarBatchSuite extends SparkFunSuite {
         batch.close()
         allocator.close()
       }
    +
    +  testVector("getUTF8String should return null for null slot", 4, StringType) {
    --- End diff --
    
    we already have test cases for each type, can we just change the existing test cases a little to add this null check?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org