You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Karthik Ranganathan <ka...@gmail.com> on 2010/07/23 23:26:01 UTC
Re: Review Request: HBASE-2866 Region permanently offlined
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/380/
-----------------------------------------------------------
(Updated 2010-07-23 14:26:01.718168)
Review request for hbase, stack and Kannan Muthukkaruppan.
Changes
-------
Adding hbase group
Summary
-------
Region permanently offlined - if the ZNode is already in the target state, do not update it again.
This addresses bug HBASE-2866.
http://issues.apache.org/jira/browse/HBASE-2866
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 967128
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 967128
Diff: http://review.hbase.org/r/380/diff
Testing
-------
Ran unit tests, went through fine (except TestRowAtomicity, which is known to be failing).
Thanks,
Karthik
Re: Review Request: HBASE-2866 Region permanently offlined
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/380/#review474
-----------------------------------------------------------
Ship it!
Just one comment
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
<http://review.hbase.org/r/380/#comment1965>
What is the watcher being triggered if data is not changing?
- stack
On 2010-07-23 15:08:16, Karthik Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/380/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 15:08:16)
>
>
> Review request for hbase, stack and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Region permanently offlined - if the ZNode is already in the target state, do not update it again.
>
>
> This addresses bug HBASE-2866.
> http://issues.apache.org/jira/browse/HBASE-2866
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 967128
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 967128
>
> Diff: http://review.hbase.org/r/380/diff
>
>
> Testing
> -------
>
> Ran unit tests, went through fine (except TestRowAtomicity, which is known to be failing).
>
>
> Thanks,
>
> Karthik
>
>
Re: Review Request: HBASE-2866 Region permanently offlined
Posted by Jean-Daniel Cryans <jd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/380/#review473
-----------------------------------------------------------
Ship it!
+1 LGTM and TestAdmin passes on my machine without flinching
- Jean-Daniel
On 2010-07-23 15:08:16, Karthik Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/380/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 15:08:16)
>
>
> Review request for hbase, stack and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Region permanently offlined - if the ZNode is already in the target state, do not update it again.
>
>
> This addresses bug HBASE-2866.
> http://issues.apache.org/jira/browse/HBASE-2866
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 967128
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 967128
>
> Diff: http://review.hbase.org/r/380/diff
>
>
> Testing
> -------
>
> Ran unit tests, went through fine (except TestRowAtomicity, which is known to be failing).
>
>
> Thanks,
>
> Karthik
>
>
Re: Review Request: HBASE-2866 Region permanently offlined
Posted by Karthik Ranganathan <ka...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/380/
-----------------------------------------------------------
(Updated 2010-07-23 15:08:16.286786)
Review request for hbase, stack and Kannan Muthukkaruppan.
Changes
-------
Addressed some comments (re-use variables, removed white spaces)
Summary
-------
Region permanently offlined - if the ZNode is already in the target state, do not update it again.
This addresses bug HBASE-2866.
http://issues.apache.org/jira/browse/HBASE-2866
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 967128
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 967128
Diff: http://review.hbase.org/r/380/diff
Testing
-------
Ran unit tests, went through fine (except TestRowAtomicity, which is known to be failing).
Thanks,
Karthik
Re: Review Request: HBASE-2866 Region permanently offlined
Posted by Jean-Daniel Cryans <jd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/380/#review471
-----------------------------------------------------------
Some nits, I'm also trying it out (with the update=true fix)
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
<http://review.hbase.org/r/380/#comment1962>
Remove all the trailing white spaces
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
<http://review.hbase.org/r/380/#comment1963>
Reuse curState and newState instead
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
<http://review.hbase.org/r/380/#comment1961>
Simply return when you figure that you should, then you can get rid of "update"
- Jean-Daniel
On 2010-07-23 14:53:37, Karthik Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/380/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 14:53:37)
>
>
> Review request for hbase, stack and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Region permanently offlined - if the ZNode is already in the target state, do not update it again.
>
>
> This addresses bug HBASE-2866.
> http://issues.apache.org/jira/browse/HBASE-2866
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 967128
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 967128
>
> Diff: http://review.hbase.org/r/380/diff
>
>
> Testing
> -------
>
> Ran unit tests, went through fine (except TestRowAtomicity, which is known to be failing).
>
>
> Thanks,
>
> Karthik
>
>
Re: Review Request: HBASE-2866 Region permanently offlined
Posted by Karthik Ranganathan <ka...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/380/
-----------------------------------------------------------
(Updated 2010-07-23 14:53:37.123965)
Review request for hbase, stack and Kannan Muthukkaruppan.
Changes
-------
Good catch Kannan... updated the diff with comments this time.
Summary
-------
Region permanently offlined - if the ZNode is already in the target state, do not update it again.
This addresses bug HBASE-2866.
http://issues.apache.org/jira/browse/HBASE-2866
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 967128
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 967128
Diff: http://review.hbase.org/r/380/diff
Testing
-------
Ran unit tests, went through fine (except TestRowAtomicity, which is known to be failing).
Thanks,
Karthik