You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lucasssvaz (via GitHub)" <gi...@apache.org> on 2023/05/25 00:00:46 UTC
[GitHub] [nuttx] lucasssvaz opened a new pull request, #9379: Add nxdiag documentation and example defconfig
lucasssvaz opened a new pull request, #9379:
URL: https://github.com/apache/nuttx/pull/9379
## Summary
Requires apache/nuttx-apps#1774.
This MR aims to add documentation for the new nxdiag documentation and provide an example defconfig.
## Impact
None on existing code.
## Testing
Tested using ESP32-DevKitC with the provided defconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9379: Add nxdiag documentation and example defconfig
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9379:
URL: https://github.com/apache/nuttx/pull/9379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #9379: Add nxdiag documentation and example defconfig
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #9379:
URL: https://github.com/apache/nuttx/pull/9379#discussion_r1209287421
##########
tools/Makefile.host:
##########
@@ -104,6 +104,15 @@ ifdef HOSTEXEEXT
mkversion: mkversion$(HOSTEXEEXT)
endif
+# mkinfo - Convert a .info file into a C info.h file
+
+mkinfo$(HOSTEXEEXT): mkinfo.c cfgdefine.c
Review Comment:
@xiaoxiang781216 I suggest keep it as C to avoid dependence on python, case nxdialog become something adopted broadly for all arches. If eventually we got a C compiler like TCC working on NuttX we could compile NuttX inside a NuttX board. But if python is a requirement, it could make things hard to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz closed pull request #9379: Add nxdiag documentation and example defconfig
Posted by "lucasssvaz (via GitHub)" <gi...@apache.org>.
lucasssvaz closed pull request #9379: Add nxdiag documentation and example defconfig
URL: https://github.com/apache/nuttx/pull/9379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9379: Add nxdiag documentation and example defconfig
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9379:
URL: https://github.com/apache/nuttx/pull/9379#discussion_r1207711339
##########
tools/Makefile.host:
##########
@@ -104,6 +104,15 @@ ifdef HOSTEXEEXT
mkversion: mkversion$(HOSTEXEEXT)
endif
+# mkinfo - Convert a .info file into a C info.h file
+
+mkinfo$(HOSTEXEEXT): mkinfo.c cfgdefine.c
Review Comment:
why not use the similar approach of https://github.com/apache/nuttx-apps/blob/master/tools/host_sysinfo.py to generate nuttx info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org