You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/04/08 20:32:11 UTC
Review Request 45936: Remove support for reading command line argument
values from files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45936/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
This was an un-advertised feature. I believe it existed as a workaround to pass sensitive argument values (like credentials) so that they were not revealed in `ps` output.
Diffs
-----
RELEASE-NOTES.md 0ca6486f30d245b2ca1ca08f6a9ca71d29d4bd7b
commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 908553ce2fdb16d0e69b458823deb7f165550b93
commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java ca309a2b3d44f94e9f91d0690f810fe7bc646aed
commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 12714949f433ec6b5d7c2794c2f31d82773174e7
commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 48737d4a831ab62945e48e4b9540a18ca2e2abab
commons/src/test/java/org/apache/aurora/common/args/OptionInfoTest.java 98d951912627bfbf49e75037bccc914a430a45f4
Diff: https://reviews.apache.org/r/45936/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 45936: Remove support for reading command line
argument values from files.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45936/#review127837
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 8, 2016, 11:32 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45936/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 11:32 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This was an un-advertised feature. I believe it existed as a workaround to pass sensitive argument values (like credentials) so that they were not revealed in `ps` output.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0ca6486f30d245b2ca1ca08f6a9ca71d29d4bd7b
> commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 908553ce2fdb16d0e69b458823deb7f165550b93
> commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java ca309a2b3d44f94e9f91d0690f810fe7bc646aed
> commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 12714949f433ec6b5d7c2794c2f31d82773174e7
> commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 48737d4a831ab62945e48e4b9540a18ca2e2abab
> commons/src/test/java/org/apache/aurora/common/args/OptionInfoTest.java 98d951912627bfbf49e75037bccc914a430a45f4
>
> Diff: https://reviews.apache.org/r/45936/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45936: Remove support for reading command line
argument values from files.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45936/
-----------------------------------------------------------
(Updated April 8, 2016, 12:20 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
rebase
Repository: aurora
Description
-------
This was an un-advertised feature. I believe it existed as a workaround to pass sensitive argument values (like credentials) so that they were not revealed in `ps` output.
Diffs (updated)
-----
RELEASE-NOTES.md 30e2275588a81aeba8a10e77beb1cdc7071476a5
commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 46bd0c7e2e3b422036ffb60b6334030f58aedec9
commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java e28bae265521a3995e4f0029453bf2d69687121c
commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 36a472deb7cee494df5ba5fc72952325c999f00c
commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 466b8e2219afef7e02ad50145b06416f5f045a7c
commons/src/test/java/org/apache/aurora/common/args/OptionInfoTest.java 58890ab1295dca6bb884bd414486a56de0938d6a
Diff: https://reviews.apache.org/r/45936/diff/
Testing
-------
Thanks,
Bill Farner