[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #1682: infra: Introduce justfile for workflow

["suyanhanx (via GitHub)" <gi...@apache.org>]

suyanhanx commented on code in PR #1682:
URL: https://github.com/apache/incubator-opendal/pull/1682#discussion_r1141281834


##########
bindings/python/README.md:
##########
@@ -34,33 +34,14 @@ asyncio.run(main())
 
 ## Development
 
-Setup virtualenv:
-
-```shell
-python -m venv venv
-```
-
-Activate venv:
-
-```shell
-source venv/bin/activate
-````
-
-Install `maturin`:
-
-```shell
-pip install maturin[patchelf]
-```
-
 Build bindings:
 
 ```shell
-maturin develop
+just build_bindings_python

Review Comment:
   This kind of integration is very confusing.
   `just` will not prepare the environment for developers.



##########
core/CONTRIBUTING.md:
##########


Review Comment:
   We should provide more detailed instructions to new developers on how to set up the environment, develop and test, and submit their own PRs.



##########
Justfile:
##########


Review Comment:
   This may be more suitable for CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org