You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2022/10/20 20:21:01 UTC
[superset] branch lyndsi/table-selected-visuals updated (1857cf3129 -> ed095c1065)
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a change to branch lyndsi/table-selected-visuals
in repository https://gitbox.apache.org/repos/asf/superset.git
discard 1857cf3129 Add table selected visuals
omit 410558538b Fix table search test in LeftPanel
omit 06b1202b9f Debugging LeftPanel.test.tsx
omit ead3c2baa4 Add client side searching to table list in dataset left panel
add ab53d77aba fix(dashboard): fix Pivot Table V2 dragPreview in the dashboard (#21539)
add 71bf267307 fix(sqllab): SqlEditorLeftBar listening to database changes (#21628)
add b787c3fef4 feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs (#21444)
add ab7cfec975 feat: new config to filter specific users from dropdown lists (#21515)
add 5ea9249059 fix: respect chart cache timeout setting (#21637)
add 0dda5fe1cf feat: Adds the MetadataBar to the Explore header (#21560)
add 7f971b4103 fix(report): Fix permission check for set up email report on charts/dashboards. Fixes #21559 (#21561)
add f3465f5b22 chore(deps): bump minimist from 0.0.5 to 1.2.6 in /superset-frontend (#21654)
add 9dd102f383 refactor: remove useless groupby from QueryObject (#21643)
add f83af88fc7 feat: Added latin america countries to country map (#21352)
add 6af35a7d98 fix: Selected tab after save and go to dashboard (#21630)
add b2a360fa14 fix: Switch tab on drag hover (#21648)
add eeb979c150 chore: Create dashboard with tier 1 and tier 2 charts (#21551)
add 389fa31b89 fix: new welcome new users action (#21662)
add 1d70079f71 fix(dashboard): Change text and icons in dashboard editmode (#21305)
add 4c17f0e71e fix: time grain can't be removed in explore (#21644)
add 61bd696226 fix(plugin-chart-echarts): boxplot throw error in the dashboard (#21661)
add c1ba3290d9 docs: add organization that uses superset (#21660)
add ef78ec6b30 fix: catch error when masking encrypted extra is none (#21570)
add 157482955e chore: avoid undefined property on `Global` type (#21631)
add 8d1b7ecfde fix(sqllab): perf regression on #21532 refactor (#21632)
add 31895f412e chore(tags): Refactor logic to leverage Flask-SQLAlchemy extension (#21459)
add 3edc656f20 fix(explore): Dashboard list is unsorted in save modal (#21317)
add 4245bc3f38 chore(style): Enforce optional chaining (#21614)
add 4d0c2ba6ef fix: Allow clickhouse dbs with timestamps to visualize queries (#21446)
add 84c3cf66ea fix: add logging to alerts and reports to find non-triggering issues (#21684)
add 4417c6e3e2 chore: add 4xx error codes where applicable (#21627)
add e98943e580 refactor: pass all properties to validate_parameters (#21487)
add abc0f19f08 docs: add Wise to users list (#21687)
add 5da20f449d fix(migration): Catch DatabaseError to avoid migration crash with MySQL 8.0 (#21679)
add 3057e4270c feat: deprecate created_slices API endpoint (#21664)
add f784455264 fix(native-filters): Range filter max/min default display value (#21680)
add 640628952e chore(dep): Unpin slackclient dependency (#21586)
add 2907869c26 feat: Use SPA navigation between AddSlice and Dataset list pages (#21683)
add c248ee56e4 chore: Adding/categorizing missing flags in `FEATURE_FLAGS.md` (#21474)
add f3f9f3b1f2 other: Improve health check for docker-compose. (#17320)
add 50cb396bf2 fix(sqllab): async query broken due to #21320 (#21667)
add ebd75366c0 feat(chart): add feature flag that displays the data pane closes by default (#21649)
add de444d4de6 fix: Race conditions with setupExtensions (#21647)
add b6891aaa9f chore(key-value): remove redundant exception logging (#21702)
add 7b66e0bb34 chore: E2E tests for Drill to Detail supported Charts (#21681)
add 51c54b3c9b fix: add `get_column` function for Query obj (#21691)
add 05648eb489 feat: support None operand in EQUAL operator (#21713)
add d6a82187a7 docs(cache): update datasource -> dataset (#21670)
add 770f68f5b1 fix: Right-click on misconfigured World Map (#21697)
add 1cbf066415 feat: Adds the CROSS_REFERENCE feature flag (#21708)
add f1fbaf8244 fix: Pass slice_id in Explore get (#21696)
add 041c54e656 build: optimize docker build by better utilizing build cache (#21583)
add eb2a1345a8 fix: Drill to detail formatted val on TableChart (#21719)
add 97273f59f8 fix(database): Handle String errors in DatabaseModal (#21709)
add 882bfb67ae fix: gsheets editing with dynamic forms (#21710)
add 61319fd759 feat(sqllab): save query parameters in database (#21682)
add 0ff1e49e3c fix: Null values on Treemap right-click (#21722)
add 200bed6f7e feat: Shows related dashboards in Explore (#21685)
add 35d9cb38a8 fix(explore): chart link is broken without localStorage (#21707)
add ca3abffb81 docs: wording in template (#21491)
add 1372b0dff5 docs(snowflake): Remove wrong version info for snowflake (#21024)
add f42516887d chore: Slovenian translation update (#20435)
add a5ff0949a6 feat(api): Add option to enable sync on import (#20312)
add 0c461497ff chore(sqllab): refactor addQueryEditor for new tab (#21711)
add aef6217a80 fix: Gsheets takes 2 clicks to save (#21740)
add f58227a912 feat: add denylist for db engines (#21486)
add d1a6f0ebc4 fix: allow adhoc columns in non-aggregate query (#21729)
add 20b9dc8444 feat(embedded-dashboard): Share Switchboard State for Sending Events from Plugins (#21319)
add 91f0de0c5d fix: database schema selector on import data (#21759)
add d7ee443a13 fix(sqllab): resultset disappeared on switching tabs (#21741)
add db075d4157 chore(deps): bump react-map-gl from 4.0.10 to 6.1.19 (#21748)
add ba3275a4d0 fix: flash message on database data upload forms (#21761)
add 070b865e32 chore(explore): Add tests for getControlValuesCompatibleWithDatasource (#21744)
add 406e44bba1 perf(dashboard): Virtualization POC (#21438)
add d21e1d799d fix(sqllab): Async queries are now fetched properly (#21698)
add 605b6920a6 fix(datasets): Stop showing alert when saving from query (#21442)
add bd3166b603 chore: cleanup on catalog check for Gsheets (#21738)
add 8f61e3c5d9 refactor: preparation for time section migration (#21766)
add 8f74e46d45 fix: regression in #21766 (#21782)
add 75e6a04269 fix: remove deprecated ETagResponseMixin (#21773)
add 11d7d6e078 fix: Preserve unknown URL params (#21785)
add 88a89c9fd6 fix(migration): Ensure the paginated update is deterministic (#21778)
add 3936e9ed5f fix: Fix regression introduced in #20893 (#21743)
add d5b4bdeb72 fix(plugin-chart-handlebars): Update webpack/babel config to fix build/runtime warnings/errors (#21779)
add 49b48eeca4 feat: Cross-referenced Dashboards in Chart list (Column + Filter) (#21760)
add e6c44e02cb chore: stop logging "SyntaxError" as exceptions (#21787)
add 2258fbf878 fix(CustomFrame): Resolves issue #21731 where date range in explore throws runtime error (#21776)
add f4fa2e1115 chore: add more logging for alerts and reports (#21714)
add b1bf25e98c fix(explore): Persist URL params to form-data (#21792)
add df3b5a8305 fix: Dataset creation header is now uneditable and holds proper default values (#21557)
add 196c3671e2 refactor: serialize extra json in state (#21523)
add 4c1777f20d fix(alerts): restrict list view and gamma perms (#21765)
add 6f2e76bc09 chore: Add `USER_CLIENT_ERRORS` to stop logging exceptions that are user driven (#21818)
add 7ec136fec2 fix(superset-embedded-sdk): Buffer is not defined (#21641)
add 7a7181a244 feat(color): color consistency enhancements (#21507)
add 52d33b05fd chore(sqla): refactor query utils (#21811)
add fcb98003a3 fix(sqllab): Fix spacing on Schedule option in SqlEditor dropdown (#21832)
add 8f4415bc83 fix: Dataset left panel now uses client side search (#21770)
add 383dc29ad1 fix: Allow comma in Number Format (#21817)
add f41d0b0cbf fix: drilling on the categorical xaxis on the stacked barchart v2 (#21844)
add f38115489b fix: drilling on the categorical xaxis on the mixed chart (#21845)
add df7840c041 chore: Added translate functions (#21816)
add b77335494a docs: 414 (#21849)
add 0a4ecca9f2 fix: custom SQL in the XAxis (#21847)
add 47b1e0ca9d feat: Disables HTML rendering in Toast by default (#21853)
add 9aa804e070 fix: categorical x-axis can't apply the label of column (#21869)
add 7c4102c20e feat(select filter): add CRLF separator for Windows (#21867)
add ec20c0104e fix(dashboard): Prevent XSS attack vector (#21822)
add cddc361adc feat(explore): Don't discard controls with custom sql when changing datasource (#20934)
add decb2fb591 feat(datasets): Change in API to create virtual datasets (#21840)
add 54f6fd6a82 fix: docker links (#21797)
add 76e57ec651 feat(dashboard): menu improvements, fallback support for Drill to Detail (#21351)
add 28c7636c59 fix: Change timer font to monospace (#21876)
add b17ef18aae chore: Color consistency E2E tests (#21622)
add f4da74ce8d feat: Adds a Content Security Policy (CSP) check for production environments (#21874)
add 9a063abb3b feat(explore): add config for default time filter (#21879)
new fa4f6a4fd0 Add client side searching to table list in dataset left panel
new 47bac70a64 Debugging LeftPanel.test.tsx
new ed095c1065 Add table selected visuals
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (1857cf3129)
\
N -- N -- N refs/heads/lyndsi/table-selected-visuals (ed095c1065)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/CODEOWNERS | 4 +-
.github/workflows/welcome-new-users.yml | 3 +-
CONTRIBUTING.md | 2 +-
Dockerfile | 64 +-
RESOURCES/FEATURE_FLAGS.md | 47 +-
RESOURCES/INTHEWILD.md | 4 +
UPDATING.md | 2 +
docker-compose-non-dev.yml | 6 +
docker-compose.yml | 8 +
docker/README.md | 4 +-
docs/docs/databases/snowflake.mdx | 2 +-
docs/docs/installation/cache.mdx | 4 +-
docs/docs/security.mdx | 22 +
docs/static/resources/openapi.json | 325 +-
requirements/base.txt | 24 +-
setup.py | 6 +-
superset-embedded-sdk/package-lock.json | 13 +-
superset-embedded-sdk/package.json | 3 +-
superset-embedded-sdk/src/guestTokenRefresh.ts | 3 +-
superset-embedded-sdk/src/index.ts | 13 +-
superset-frontend/.eslintrc.js | 1 +
superset-frontend/babel.config.js | 6 +
.../new-chart-2022-09-09T14-22-31.728Z.jpg | Bin 16879 -> 0 bytes
.../cypress/integration/chart_list/filter.test.ts | 18 +-
.../cypress/integration/chart_list/list.test.ts | 9 +-
.../integration/dashboard/drilltodetail.test.ts | 663 +-
.../cypress/integration/dashboard/editmode.test.ts | 586 +-
.../integration/dashboard/nativeFilters.test.ts | 3 +-
.../cypress/integration/dashboard/utils.ts | 23 +-
.../integration/dashboard_list/list.test.ts | 4 +-
.../cypress/integration/explore/utils.ts | 4 +
.../explore/visualizations/area.test.js | 12 +-
.../explore/visualizations/big_number.test.js | 10 +-
.../visualizations/big_number_total.test.js | 10 +-
.../explore/visualizations/box_plot.test.js | 12 +-
.../explore/visualizations/bubble.test.js | 34 +-
.../explore/visualizations/compare.test.js | 12 +-
.../explore/visualizations/dist_bar.test.js | 21 +-
.../explore/visualizations/download_chart.test.js | 2 +-
.../explore/visualizations/dual_line.test.js | 12 +-
.../explore/visualizations/gauge.test.js | 17 +-
.../explore/visualizations/graph.test.ts | 12 +-
.../explore/visualizations/histogram.test.ts | 12 +-
.../explore/visualizations/line.test.ts | 6 +-
.../integration/explore/visualizations/pie.test.js | 12 +-
.../explore/visualizations/pivot_table.test.js | 10 +-
.../explore/visualizations/sankey.test.js | 12 +-
.../explore/visualizations/sunburst.test.js | 12 +-
.../explore/visualizations/table.test.ts | 10 +-
.../explore/visualizations/time_table.js | 6 +-
.../explore/visualizations/treemap.test.js | 12 +-
.../explore/visualizations/world_map.test.js | 12 +-
.../cypress-base/cypress/support/index.d.ts | 6 +
.../cypress-base/cypress/support/index.ts | 29 +
.../cypress-base/cypress/utils/urls.ts | 3 +-
superset-frontend/package-lock.json | 588 +-
superset-frontend/package.json | 3 +-
.../plugin-chart/templates/src/MyChart.erb | 2 +-
.../src/components/labelUtils.tsx | 6 +-
.../superset-ui-chart-controls/src/index.ts | 2 +-
.../src/operators/pivotOperator.ts | 4 +-
.../src/operators/prophetOperator.ts | 4 +-
.../src/operators/renameOperator.ts | 4 +-
.../src/operators/timeComparePivotOperator.ts | 4 +-
.../src/sections/advancedAnalytics.tsx | 16 +-
.../src/sections/echartsTimeSeriesQuery.tsx | 21 +-
.../src/sections/forecastInterval.tsx | 24 +-
.../src/sections/sections.tsx | 8 +-
.../src/shared-controls/dndControls.tsx | 11 +-
.../src/shared-controls/index.tsx | 27 +-
.../src/shared-controls/mixins.tsx | 7 +-
.../superset-ui-chart-controls/test/fixtures.ts | 10 +-
.../test/utils/getTemporalColumns.test.ts | 2 +-
.../superset-ui-core/src/chart/types/Base.ts | 13 +
.../src/color/CategoricalColorScale.ts | 25 +-
.../src/color/SharedLabelColorSingleton.ts | 148 +-
.../packages/superset-ui-core/src/color/index.ts | 1 +
.../src/components/SafeMarkdown.tsx | 2 +-
.../src/connection/callApi/callApi.ts | 2 +-
.../superset-ui-core/src/models/Registry.ts | 2 +-
.../superset-ui-core/src/query/constants.ts | 17 +-
.../superset-ui-core/src/query/getXAxis.ts | 22 +-
.../packages/superset-ui-core/src/query/index.ts | 8 +-
.../superset-ui-core/src/query/types/Column.ts | 7 +
.../packages/superset-ui-core/src/types/index.ts | 2 +
.../superset-ui-core/src/utils/featureFlags.ts | 62 +-
.../superset-ui-core/src/utils/isDefined.ts | 2 +-
.../test/color/CategoricalColorScale.test.ts | 2 +-
.../test/color/SharedLabelColorSingleton.test.ts | 121 +-
.../packages/superset-ui-switchboard/src/index.ts | 3 +
.../src/switchboard.test.ts | 31 +-
.../superset-ui-switchboard/src/switchboard.ts | 36 +-
.../scripts/Country Map GeoJSON Generator.ipynb | 714 +-
.../src/countries.ts | 38 +
.../src/countries/argentina.geojson | 30 +
.../src/countries/bolivia.geojson | 15 +
.../src/countries/chile.geojson | 22 +
.../src/countries/colombia.geojson | 40 +
.../src/countries/costa rica.geojson | 13 +
.../src/countries/cuba.geojson | 22 +
.../src/countries/dominican republic.geojson | 38 +
.../src/countries/ecuador.geojson | 30 +
.../src/countries/el salvador.geojson | 20 +
.../src/countries/guatemala.geojson | 28 +
.../src/countries/haiti.geojson | 16 +
.../src/countries/honduras.geojson | 24 +
.../src/countries/nicaragua.geojson | 23 +
.../src/countries/panama.geojson | 18 +
.../src/countries/paraguay.geojson | 24 +
.../src/countries/puerto rico.geojson | 7 +
.../src/countries/saint barthelemy.geojson | 7 +
.../src/countries/saint martin.geojson | 7 +
.../src/countries/venezuela.geojson | 32 +
.../legacy-plugin-chart-map-box/package.json | 38 +-
.../src/controlPanel.tsx | 8 +-
.../legacy-plugin-chart-world-map/src/WorldMap.js | 32 +-
.../legacy-plugin-chart-world-map/src/index.js | 3 +-
.../legacy-preset-chart-deckgl/package.json | 10 +-
.../legacy-preset-chart-nvd3/src/NVD3Controls.tsx | 8 +-
.../src/vendor/superset/AnnotationTypes.js | 10 +-
.../src/BigNumber/BigNumberTotal/index.ts | 3 +-
.../src/BigNumber/BigNumberTotal/transformProps.ts | 2 +-
.../src/BigNumber/BigNumberViz.tsx | 14 +-
.../BigNumber/BigNumberWithTrendline/buildQuery.ts | 6 +-
.../BigNumberWithTrendline/controlPanel.tsx | 31 +-
.../src/BigNumber/BigNumberWithTrendline/index.ts | 3 +-
.../BigNumberWithTrendline/transformProps.ts | 6 +-
.../src/BoxPlot/controlPanel.ts | 10 +-
.../plugin-chart-echarts/src/BoxPlot/index.ts | 2 +-
.../plugin-chart-echarts/src/Funnel/index.ts | 2 +-
.../plugin-chart-echarts/src/Gauge/buildQuery.ts | 1 -
.../plugin-chart-echarts/src/Gauge/index.ts | 2 +-
.../src/Graph/EchartsGraph.tsx | 6 +-
.../plugin-chart-echarts/src/Graph/index.ts | 3 +-
.../plugin-chart-echarts/src/Graph/types.ts | 4 +-
.../src/MixedTimeseries/EchartsMixedTimeseries.tsx | 47 +-
.../src/MixedTimeseries/buildQuery.ts | 6 +-
.../src/MixedTimeseries/controlPanel.tsx | 9 +-
.../src/MixedTimeseries/index.ts | 11 +-
.../src/MixedTimeseries/transformProps.ts | 30 +-
.../src/MixedTimeseries/types.ts | 5 +
.../plugin-chart-echarts/src/Pie/controlPanel.tsx | 1 +
.../plugins/plugin-chart-echarts/src/Pie/index.ts | 2 +-
.../plugin-chart-echarts/src/Radar/index.ts | 2 +-
.../src/Timeseries/Area/index.ts | 9 +-
.../src/Timeseries/EchartsTimeseries.tsx | 41 +-
.../src/Timeseries/Regular/Bar/index.ts | 9 +-
.../src/Timeseries/Regular/Line/index.ts | 9 +-
.../src/Timeseries/Regular/Scatter/index.ts | 9 +-
.../src/Timeseries/Regular/SmoothLine/index.ts | 9 +-
.../src/Timeseries/Step/index.ts | 9 +-
.../src/Timeseries/buildQuery.ts | 6 +-
.../plugin-chart-echarts/src/Timeseries/index.ts | 11 +-
.../src/Timeseries/transformProps.ts | 26 +-
.../src/Timeseries/transformers.ts | 8 +-
.../plugin-chart-echarts/src/Timeseries/types.ts | 12 +-
.../src/Treemap/EchartsTreemap.tsx | 12 +-
.../plugin-chart-echarts/src/Treemap/index.ts | 2 +-
.../plugins/plugin-chart-echarts/src/controls.tsx | 16 +-
.../plugins/plugin-chart-echarts/src/types.ts | 6 +-
.../plugin-chart-echarts/src/utils/annotation.ts | 3 +-
.../src/utils/eventHandlers.ts | 6 +-
.../plugin-chart-echarts/src/utils/series.ts | 7 +-
.../test/Gauge/buildQuery.test.ts | 6 +-
.../test/utils/annotation.test.ts | 16 +-
.../src/plugin/buildQuery.ts | 3 -
.../plugin-chart-handlebars/src/plugin/index.ts | 2 +-
.../test/plugin/buildQuery.test.ts | 2 +-
.../src/PivotTableChart.tsx | 7 +-
.../src/plugin/buildQuery.ts | 7 +-
.../src/plugin/controlPanel.tsx | 9 +-
.../plugin-chart-pivot-table/src/plugin/index.ts | 2 +-
.../src/react-pivottable/Styles.js | 8 +-
.../src/react-pivottable/TableRenderers.jsx | 6 +-
.../plugins/plugin-chart-pivot-table/src/types.ts | 4 +-
.../plugin-chart-table/src/DataTable/DataTable.tsx | 1 +
.../plugins/plugin-chart-table/src/TableChart.tsx | 11 +-
.../plugins/plugin-chart-table/src/buildQuery.ts | 5 +-
.../plugin-chart-table/src/controlPanel.tsx | 7 +-
.../plugins/plugin-chart-table/src/index.ts | 2 +-
.../plugins/plugin-chart-table/src/types.ts | 4 +-
.../spec/fixtures/mockChartQueries.js | 6 +-
superset-frontend/spec/helpers/testing-library.tsx | 2 +-
superset-frontend/src/SqlLab/App.jsx | 2 +
superset-frontend/src/SqlLab/actions/sqlLab.js | 66 +-
.../src/SqlLab/actions/sqlLab.test.js | 52 +-
.../AceEditorWrapper/AceEditorWrapper.test.tsx | 2 +-
.../SqlLab/components/AceEditorWrapper/index.tsx | 20 +-
.../QueryLimitSelect/QueryLimitSelect.test.tsx | 24 +-
.../SqlLab/components/QueryLimitSelect/index.tsx | 19 +-
.../SqlLab/components/ResultSet/ResultSet.test.tsx | 83 +-
.../src/SqlLab/components/ResultSet/index.tsx | 6 +-
.../RunQueryActionButton.test.tsx | 177 +-
.../components/RunQueryActionButton/index.tsx | 41 +-
.../{SaveQuery.test.jsx => SaveQuery.test.tsx} | 55 +-
.../src/SqlLab/components/SaveQuery/index.tsx | 81 +-
.../components/ScheduleQueryButton/index.tsx | 2 +
...LabQuery.test.jsx => ShareSqlLabQuery.test.tsx} | 59 +-
.../SqlLab/components/ShareSqlLabQuery/index.tsx | 21 +-
.../SqlLab/components/SqlEditor/SqlEditor.test.jsx | 55 +-
.../src/SqlLab/components/SqlEditor/index.jsx | 56 +-
.../SqlEditorLeftBar/SqlEditorLeftBar.test.jsx | 89 +-
.../SqlLab/components/SqlEditorLeftBar/index.tsx | 16 +-
.../SqlLab/components/SqlEditorTabHeader/index.tsx | 2 +-
.../TabbedSqlEditors/TabbedSqlEditors.test.jsx | 47 +-
.../SqlLab/components/TabbedSqlEditors/index.jsx | 6 +-
superset-frontend/src/SqlLab/fixtures.ts | 12 +-
.../hooks/useQueryEditor/index.ts} | 30 +-
.../hooks/useQueryEditor/useQueryEditor.test.ts | 92 +
superset-frontend/src/SqlLab/reducers/sqlLab.js | 6 +-
.../src/addSlice/AddSliceContainer.tsx | 13 +-
superset-frontend/src/components/Chart/Chart.jsx | 22 +-
.../src/components/Chart/ChartContextMenu.tsx | 110 +-
.../src/components/Chart/ChartRenderer.jsx | 123 +-
.../DrillDetail/DrillDetailMenuItems.test.tsx | 345 +
.../Chart/DrillDetail/DrillDetailMenuItems.tsx | 236 +
.../{ => DrillDetail}/DrillDetailModal.test.tsx | 97 +-
.../Chart/{ => DrillDetail}/DrillDetailModal.tsx | 93 +-
.../Chart/DrillDetail}/DrillDetailPane.test.tsx | 7 +-
.../Chart/DrillDetail}/DrillDetailPane.tsx | 38 +-
.../DrillDetail/DrillDetailTableControls.test.tsx} | 2 +-
.../DrillDetail/DrillDetailTableControls.tsx} | 0
.../Chart/DrillDetail}/index.ts | 2 +-
.../Chart/DrillDetail}/types.ts | 4 +-
.../Chart/DrillDetail}/utils.ts | 0
.../src/components/Chart/chartReducer.ts | 5 +-
.../src/components/ConfirmStatusChange/index.tsx | 2 +-
.../src/components/Datasource/CollectionTable.tsx | 4 +-
.../src/components/Datasource/DatasourceModal.tsx | 2 +-
.../ErrorMessage/DatabaseErrorMessage.tsx | 19 +-
.../src/components/FacePile/index.tsx | 4 +-
.../src/components/FilterableTable/index.tsx | 29 +-
.../src/components/ListView/CrossLinks.test.tsx | 97 +
.../src/components/ListView/CrossLinks.tsx | 122 +
.../components/ListView/CrossLinksTooltip.test.tsx | 89 +
.../src/components/ListView/CrossLinksTooltip.tsx | 73 +
.../src/components/ListView/Filters/index.tsx | 3 +-
.../src/components/MessageToasts/Toast.tsx | 2 +-
.../src/components/MessageToasts/types.ts | 2 +
.../src/components/MetadataBar/ContentConfig.tsx | 13 +-
.../src/components/MetadataBar/ContentType.ts | 4 +-
.../components/MetadataBar/MetadataBar.stories.tsx | 2 +-
.../components/MetadataBar/MetadataBar.test.tsx | 29 +-
.../src/components/MetadataBar/MetadataBar.tsx | 66 +-
.../HeaderReportDropdown/index.test.tsx | 61 +
.../ReportModal/HeaderReportDropdown/index.tsx | 2 +-
.../src/components/Select/constants.ts | 2 +-
superset-frontend/src/components/Select/utils.tsx | 2 +-
.../src/components/TableCollection/index.tsx | 6 +-
.../src/components/TableSelector/index.tsx | 2 +-
superset-frontend/src/components/Timer/index.tsx | 1 +
superset-frontend/src/constants.ts | 4 +
.../src/dashboard/actions/dashboardState.js | 40 -
.../src/dashboard/actions/dashboardState.test.js | 2 +-
superset-frontend/src/dashboard/actions/hydrate.js | 22 +-
.../DashboardBuilder/DashboardBuilder.tsx | 2 +-
.../dashboard/components/FiltersBadge/selectors.ts | 3 +-
.../dashboard/components/Header/Header.test.tsx | 3 +-
.../src/dashboard/components/Header/index.jsx | 15 +-
.../src/dashboard/components/Header/types.ts | 3 +-
.../PropertiesModal/PropertiesModal.test.tsx | 2 +-
.../dashboard/components/PropertiesModal/index.tsx | 36 +-
.../src/dashboard/components/SliceAdder.jsx | 8 +-
.../SliceHeaderControls.test.tsx | 4 +
.../components/SliceHeaderControls/index.tsx | 34 +-
.../src/dashboard/components/dnd/DragDroppable.jsx | 2 +
.../src/dashboard/components/dnd/handleHover.js | 2 +
.../dashboard/components/gridComponents/Chart.jsx | 12 +
.../components/gridComponents/ChartHolder.test.tsx | 3 +-
.../components/gridComponents/ChartHolder.tsx | 14 +-
.../components/gridComponents/Markdown.jsx | 8 +-
.../dashboard/components/gridComponents/Row.jsx | 49 +
.../dashboard/components/gridComponents/Tab.jsx | 10 +
.../dashboard/components/gridComponents/Tabs.jsx | 1 +
.../components/gridComponents/new/NewMarkdown.jsx | 4 +-
.../nativeFilters/FilterBar/FilterBar.test.tsx | 2 +-
.../FilterBar/FilterControls/FilterControl.tsx | 2 +-
.../nativeFilters/FilterCard/DependenciesRow.tsx | 12 +-
.../nativeFilters/FilterCard/NameRow.tsx | 2 +-
.../nativeFilters/FilterCard/ScopeRow.tsx | 12 +-
.../nativeFilters/FilterCard/useFilterScope.ts | 7 +-
.../FiltersConfigModal/FiltersConfigModal.tsx | 2 +-
.../dashboard/containers/DashboardComponent.jsx | 2 -
.../src/dashboard/containers/DashboardHeader.jsx | 6 +-
.../src/dashboard/containers/DashboardPage.tsx | 23 +-
.../src/dashboard/reducers/dashboardState.js | 9 -
.../src/dashboard/reducers/dashboardState.test.js | 9 +-
superset-frontend/src/dashboard/types.ts | 4 +-
.../src/dashboard/util/filterboxMigrationHelper.ts | 5 +-
superset-frontend/src/embedded/api.tsx | 66 +
superset-frontend/src/embedded/index.tsx | 37 +-
superset-frontend/src/explore/ExplorePage.tsx | 22 +-
.../src/explore/actions/hydrateExplore.test.ts | 46 +
.../src/explore/actions/hydrateExplore.ts | 8 +-
.../src/explore/actions/saveModalActions.js | 6 +
.../explore/components/ControlPanelsContainer.tsx | 44 +-
.../components/DataTablesPane/DataTablesPane.tsx | 8 +-
.../DataTablesPane/test/DataTablesPane.test.tsx | 17 +
.../ExploreChartHeader/ExploreChartHeader.test.tsx | 34 +-
.../components/ExploreChartHeader/index.jsx | 154 +-
.../src/explore/components/ExploreChartPanel.jsx | 9 +-
.../ExploreViewContainer.test.tsx | 40 +-
.../components/ExploreViewContainer/index.jsx | 9 +-
.../explore/components/PropertiesModal/index.tsx | 5 +-
.../AnnotationLayerControl/AnnotationLayer.jsx | 24 +-
.../FormattingPopoverContent.tsx | 2 +-
.../controls/DateFilterControl/DateFilterLabel.tsx | 100 +-
.../DateFilterControl/components/AdvancedFrame.tsx | 24 +-
.../components/CustomFrame.test.tsx | 54 +
.../DateFilterControl/components/CustomFrame.tsx | 18 +-
.../components/controls/DateFilterControl/index.ts | 5 +
.../components/controls/DateFilterControl/types.ts | 11 +
.../controls/DateFilterControl/utils/constants.ts | 6 +
.../DateFilterControl/utils/dateFilterUtils.ts | 56 +-
.../DndAdhocFilterOption.tsx | 75 +
.../DndColumnSelectControl/DndColumnSelect.tsx | 45 +-
.../DndColumnSelectControl/DndFilterSelect.tsx | 49 +-
.../DndMetricSelect.test.tsx | 19 +-
.../DndColumnSelectControl/DndMetricSelect.tsx | 141 +-
.../controls/DndColumnSelectControl/Option.tsx | 10 +-
.../DndColumnSelectControl/OptionWrapper.tsx | 2 +
.../controls/DndColumnSelectControl/types.ts | 1 +
.../FilterControl/AdhocFilter/AdhocFilter.test.js | 1 +
.../controls/FilterControl/AdhocFilter/index.js | 1 +
.../index.tsx | 78 +-
.../AdhocFilterOption/AdhocFilterOption.test.tsx | 20 +-
.../FilterControl/AdhocFilterOption/index.jsx | 86 -
.../FilterControl/AdhocFilterOption/index.tsx | 77 +
.../controls/MetricControl/AdhocMetric.js | 1 +
.../controls/MetricControl/AdhocMetric.test.js | 1 +
.../controls/MetricControl/AdhocMetricOption.jsx | 3 +
.../MetricControl/MetricDefinitionValue.jsx | 3 +
.../components/controls/OptionControls/index.tsx | 13 +-
.../DashboardsSubMenu.test.tsx | 78 +
.../DashboardsSubMenu.tsx | 146 +
.../useExploreAdditionalActionsMenu/index.jsx | 25 +-
superset-frontend/src/explore/constants.ts | 4 -
.../src/explore/controlUtils/getControlState.ts | 2 +-
...etControlValuesCompatibleWithDatasource.test.ts | 287 +
.../getControlValuesCompatibleWithDatasource.ts | 7 +-
.../getFormDataWithDashboardContext.ts | 2 +-
.../exploreUtils/getParsedExploreURLParams.test.ts | 2 +-
.../exploreUtils/getParsedExploreURLParams.ts | 7 +-
superset-frontend/src/explore/fixtures.tsx | 2 -
.../src/explore/reducers/exploreReducer.js | 61 +-
superset-frontend/src/explore/types.ts | 7 +
.../components/Range/RangeFilterPlugin.test.tsx | 26 +-
.../filters/components/Range/RangeFilterPlugin.tsx | 4 +-
.../components/Select/SelectFilterPlugin.tsx | 2 +-
.../filters/components/Time/TimeFilterPlugin.tsx | 3 +-
.../useTruncation/index.ts} | 44 +-
superset-frontend/src/middleware/asyncEvent.ts | 2 +-
superset-frontend/src/modules/AnnotationTypes.js | 10 +-
superset-frontend/src/preamble.ts | 5 +-
superset-frontend/src/profile/App.tsx | 2 +
.../src/profile/components/CreatedContent.tsx | 41 +-
superset-frontend/src/reduxUtils.ts | 22 +-
superset-frontend/src/setup/setupApp.ts | 2 +-
superset-frontend/src/setup/setupClient.ts | 2 +-
.../index.ts => types/ChartSource.ts} | 5 +-
superset-frontend/src/types/Database.ts | 1 +
superset-frontend/src/types/bootstrapTypes.ts | 10 +
.../src/types/index.ts => src/utils/isBot.ts} | 6 +-
.../isDashboardVirtualizationEnabled.ts} | 19 +-
superset-frontend/src/views/App.tsx | 2 +
.../src/views/CRUD/alert/AlertList.test.jsx | 4 +-
.../src/views/CRUD/alert/AlertList.tsx | 39 +-
.../src/views/CRUD/alert/AlertReportModal.tsx | 29 +-
.../src/views/CRUD/annotation/AnnotationModal.tsx | 13 +-
.../CRUD/annotationlayers/AnnotationLayerModal.tsx | 4 +-
.../src/views/CRUD/chart/ChartList.tsx | 99 +
.../views/CRUD/csstemplates/CssTemplateModal.tsx | 12 +-
.../src/views/CRUD/dashboard/DashboardCard.tsx | 4 +-
.../src/views/CRUD/data/database/DatabaseList.tsx | 12 +-
.../data/database/DatabaseModal/ExtraOptions.tsx | 37 +-
.../data/database/DatabaseModal/ModalHeader.tsx | 7 +-
.../{index.test.jsx => index.test.tsx} | 496 +-
.../CRUD/data/database/DatabaseModal/index.tsx | 175 +-
.../src/views/CRUD/data/database/types.ts | 65 +-
.../data/dataset/AddDataset/AddDataset.test.tsx | 6 +-
.../data/dataset/AddDataset/Header/Header.test.tsx | 51 +-
.../CRUD/data/dataset/AddDataset/Header/index.tsx | 13 +-
.../data/dataset/AddDataset/LeftPanel/index.tsx | 2 +-
.../views/CRUD/data/dataset/AddDataset/index.tsx | 2 +-
.../views/CRUD/data/dataset/AddDatasetModal.tsx | 14 +-
.../dataset/DatasetLayout/DatasetLayout.test.tsx | 10 +-
superset-frontend/src/views/CRUD/hooks.ts | 17 +-
superset-frontend/src/views/CRUD/utils.tsx | 6 +-
.../src/views/CRUD/welcome/Welcome.tsx | 2 +-
.../src/views/components/RightMenu.tsx | 2 +-
superset-frontend/webpack.config.js | 3 +
superset/charts/api.py | 11 +-
superset/charts/filters.py | 16 +
superset/charts/schemas.py | 3 +-
superset/cli/examples.py | 4 +-
superset/cli/update.py | 7 +-
superset/common/query_context.py | 6 +
superset/common/query_context_factory.py | 11 +
superset/common/query_context_processor.py | 3 +-
superset/common/tags.py | 76 +-
superset/config.py | 28 +-
superset/connectors/sqla/models.py | 53 +-
superset/dashboards/api.py | 6 +-
superset/dashboards/filters.py | 2 +-
superset/databases/api.py | 4 +
superset/databases/commands/validate.py | 8 +-
superset/databases/schemas.py | 5 +
superset/datasets/api.py | 26 +-
superset/datasets/commands/create.py | 10 +-
superset/datasets/schemas.py | 1 +
superset/db_engine_specs/__init__.py | 13 +-
superset/db_engine_specs/base.py | 13 +-
superset/db_engine_specs/bigquery.py | 21 +-
superset/db_engine_specs/gsheets.py | 35 +-
superset/db_engine_specs/snowflake.py | 4 +-
superset/examples/data_loading.py | 2 +-
superset/examples/echarts_dashboard.py | 250 -
superset/examples/supported_charts_dashboard.py | 1290 +
superset/examples/tabbed_dashboard.py | 34 +-
superset/explore/commands/get.py | 29 +-
superset/initialization/__init__.py | 24 +-
superset/key_value/commands/create.py | 1 -
superset/key_value/commands/delete.py | 1 -
superset/key_value/commands/delete_expired.py | 1 -
superset/key_value/commands/get.py | 1 -
superset/key_value/commands/update.py | 1 -
superset/key_value/commands/upsert.py | 11 +-
superset/key_value/exceptions.py | 4 +
superset/migrations/shared/utils.py | 31 +-
...-09-19_14-42_b92d69a6643c_rename_csv_to_file.py | 2 +-
...59_7fb8bca906d2_permalink_rename_filterstate.py | 3 -
...34_deb4c9d4a4ef_parameters_in_saved_queries.py} | 55 +-
superset/models/core.py | 29 +-
superset/models/helpers.py | 41 +-
superset/models/slice.py | 3 +-
superset/models/sql_lab.py | 16 +-
superset/queries/api.py | 7 +-
superset/queries/saved_queries/api.py | 10 +-
superset/reports/api.py | 11 +-
superset/reports/commands/exceptions.py | 18 +-
superset/reports/commands/execute.py | 70 +-
superset/reports/dao.py | 2 +
superset/reports/filters.py | 16 +
superset/reports/notifications/slack.py | 4 +-
superset/security/manager.py | 18 +
superset/sql_lab.py | 1 -
superset/sqllab/command.py | 15 +-
superset/superset_typing.py | 4 +-
superset/tasks/scheduler.py | 5 +
superset/tasks/slack_util.py | 6 +-
.../form_view/columnar_to_database_view/edit.html | 43 +-
.../form_view/csv_to_database_view/edit.html | 43 +-
.../form_view/database_schemas_selector.html | 70 +
.../form_view/excel_to_database_view/edit.html | 43 +-
superset/translations/sl/LC_MESSAGES/messages.json | 6582 ++---
superset/translations/sl/LC_MESSAGES/messages.po | 26142 ++++++++++---------
superset/utils/cache.py | 4 +-
superset/utils/core.py | 4 +-
superset/views/base.py | 2 +
superset/views/core.py | 10 +-
superset/views/database/views.py | 22 +-
superset/views/filters.py | 34 +-
tests/integration_tests/base_api_tests.py | 52 +
tests/integration_tests/charts/api_tests.py | 40 +
tests/integration_tests/charts/data/api_tests.py | 176 +-
tests/integration_tests/conftest.py | 34 +-
tests/integration_tests/dashboards/api_tests.py | 38 +-
tests/integration_tests/datasets/api_tests.py | 59 +
.../db_engine_specs/base_engine_spec_tests.py | 72 +-
tests/integration_tests/explore/api_tests.py | 12 +
.../integration_tests/fixtures/energy_dashboard.py | 14 +-
tests/integration_tests/model_tests.py | 4 +-
.../queries/saved_queries/api_tests.py | 1 +
tests/integration_tests/reports/api_tests.py | 154 +-
tests/integration_tests/reports/commands_tests.py | 7 +-
tests/integration_tests/sqla_models_tests.py | 122 +-
tests/integration_tests/superset_test_config.py | 1 +
tests/unit_tests/conftest.py | 8 +-
tests/unit_tests/databases/api_test.py | 6 +
tests/unit_tests/databases/schema_tests.py | 1 -
tests/unit_tests/db_engine_specs/test_bigquery.py | 54 +-
tests/unit_tests/db_engine_specs/test_gsheets.py | 99 +-
tests/unit_tests/db_engine_specs/test_init.py | 80 +
483 files changed, 28018 insertions(+), 20252 deletions(-)
delete mode 100644 superset-frontend/cypress-base/cypress/downloads/new-chart-2022-09-09T14-22-31.728Z.jpg
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/argentina.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/bolivia.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/chile.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/colombia.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/costa rica.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/cuba.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/dominican republic.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/ecuador.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/el salvador.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/guatemala.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/haiti.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/honduras.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/nicaragua.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/panama.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/paraguay.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/puerto rico.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/saint barthelemy.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/saint martin.geojson
create mode 100644 superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/venezuela.geojson
rename superset-frontend/src/SqlLab/components/SaveQuery/{SaveQuery.test.jsx => SaveQuery.test.tsx} (89%)
rename superset-frontend/src/SqlLab/components/ShareSqlLabQuery/{ShareSqlLabQuery.test.jsx => ShareSqlLabQuery.test.tsx} (85%)
copy superset-frontend/src/{dashboard/components/gridComponents/new/NewMarkdown.jsx => SqlLab/hooks/useQueryEditor/index.ts} (54%)
create mode 100644 superset-frontend/src/SqlLab/hooks/useQueryEditor/useQueryEditor.test.ts
create mode 100644 superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.test.tsx
create mode 100644 superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.tsx
rename superset-frontend/src/components/Chart/{ => DrillDetail}/DrillDetailModal.test.tsx (59%)
rename superset-frontend/src/components/Chart/{ => DrillDetail}/DrillDetailModal.tsx (65%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane => components/Chart/DrillDetail}/DrillDetailPane.test.tsx (96%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane => components/Chart/DrillDetail}/DrillDetailPane.tsx (90%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane/TableControls.test.tsx => components/Chart/DrillDetail/DrillDetailTableControls.test.tsx} (98%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane/TableControls.tsx => components/Chart/DrillDetail/DrillDetailTableControls.tsx} (100%)
copy superset-frontend/src/{dashboard/components/DrillDetailPane => components/Chart/DrillDetail}/index.ts (91%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane => components/Chart/DrillDetail}/types.ts (95%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane => components/Chart/DrillDetail}/utils.ts (100%)
create mode 100644 superset-frontend/src/components/ListView/CrossLinks.test.tsx
create mode 100644 superset-frontend/src/components/ListView/CrossLinks.tsx
create mode 100644 superset-frontend/src/components/ListView/CrossLinksTooltip.test.tsx
create mode 100644 superset-frontend/src/components/ListView/CrossLinksTooltip.tsx
create mode 100644 superset-frontend/src/embedded/api.tsx
create mode 100644 superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndAdhocFilterOption.tsx
delete mode 100644 superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/index.jsx
create mode 100644 superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/index.tsx
create mode 100644 superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/DashboardsSubMenu.test.tsx
create mode 100644 superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/DashboardsSubMenu.tsx
create mode 100644 superset-frontend/src/explore/controlUtils/getControlValuesCompatibleWithDatasource.test.ts
rename superset-frontend/src/{dashboard/components/nativeFilters/FilterCard/useTruncation.ts => hooks/useTruncation/index.ts} (71%)
rename superset-frontend/src/{dashboard/components/DrillDetailPane/index.ts => types/ChartSource.ts} (91%)
copy superset-frontend/{packages/superset-ui-core/src/types/index.ts => src/utils/isBot.ts} (85%)
copy superset-frontend/src/{types/Database.ts => utils/isDashboardVirtualizationEnabled.ts} (69%)
rename superset-frontend/src/views/CRUD/data/database/DatabaseModal/{index.test.jsx => index.test.tsx} (75%)
delete mode 100644 superset/examples/echarts_dashboard.py
create mode 100644 superset/examples/supported_charts_dashboard.py
copy superset/{reports/filters.py => migrations/versions/2022-10-03_17-34_deb4c9d4a4ef_parameters_in_saved_queries.py} (51%)
create mode 100644 superset/templates/superset/form_view/database_schemas_selector.html
create mode 100644 tests/unit_tests/db_engine_specs/test_init.py
[superset] 03/03: Add table selected visuals
Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a commit to branch lyndsi/table-selected-visuals
in repository https://gitbox.apache.org/repos/asf/superset.git
commit ed095c10655120706496fd2589b99426bb7416ef
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Mon Oct 17 08:12:31 2022 -0500
Add table selected visuals
---
.../data/dataset/AddDataset/DatasetPanel/index.tsx | 59 +++++++++++++++++++---
.../data/dataset/AddDataset/LeftPanel/index.tsx | 14 ++---
.../views/CRUD/data/dataset/AddDataset/index.tsx | 11 ++--
.../dataset/DatasetLayout/DatasetLayout.test.tsx | 2 +-
4 files changed, 69 insertions(+), 17 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/index.tsx
index 294637a6f7..a36d10aa5e 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/index.tsx
@@ -17,8 +17,14 @@
* under the License.
*/
import React from 'react';
-import { t, styled } from '@superset-ui/core';
+import { supersetTheme, t, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
import { EmptyStateBig } from 'src/components/EmptyState';
+import RefreshLabel from 'src/components/RefreshLabel';
+
+type DatasetPanelProps = {
+ tableName?: string | null | undefined;
+};
const StyledEmptyStateBig = styled(EmptyStateBig)`
p {
@@ -26,7 +32,31 @@ const StyledEmptyStateBig = styled(EmptyStateBig)`
}
`;
-const renderDescription = () => (
+const StyledDatasetPanel = styled.div`
+ padding: ${({ theme }) => theme.gridUnit * 8}px
+ ${({ theme }) => theme.gridUnit * 6}px;
+
+ .table-name {
+ font-size: ${({ theme }) => theme.gridUnit * 6}px;
+ font-weight: ${({ theme }) => theme.typography.weights.medium};
+ padding-bottom: ${({ theme }) => theme.gridUnit * 20}px;
+ margin: 0;
+
+ .anticon:first-of-type {
+ margin-right: ${({ theme }) => theme.gridUnit * 4}px;
+ }
+
+ .anticon:nth-of-type(2) {
+ margin-left: ${({ theme }) => theme.gridUnit * 4}px;
+ }
+ }
+
+ span {
+ font-weight: ${({ theme }) => theme.typography.weights.bold};
+ }
+`;
+
+const renderEmptyDescription = () => (
<>
{t(
'Datasets can be created from database tables or SQL queries. Select a database table to the left or ',
@@ -44,12 +74,29 @@ const renderDescription = () => (
</>
);
-export default function DatasetPanel() {
- return (
+const DatasetPanel = ({ tableName }: DatasetPanelProps) =>
+ tableName ? (
+ <StyledDatasetPanel>
+ <div className="table-name">
+ <Icons.Table iconColor={supersetTheme.colors.grayscale.base} />
+ {tableName}
+ <RefreshLabel
+ onClick={() => {
+ console.log(
+ 'This will refresh table columns once the table component is implemented',
+ );
+ }}
+ tooltipContent={t('Refresh table columns')}
+ />
+ </div>
+ <span>{t('Table columns')}</span>
+ </StyledDatasetPanel>
+ ) : (
<StyledEmptyStateBig
image="empty-dataset.svg"
title={t('Select dataset source')}
- description={renderDescription()}
+ description={renderEmptyDescription()}
/>
);
-}
+
+export default DatasetPanel;
diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
index 0a1ed77c86..5b4104f782 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
@@ -127,6 +127,13 @@ const LeftPanelStyle = styled.div`
`}
`;
+export const Loader = (inline: string) => (
+ <div className="loading-container">
+ <Loading position="inline" />
+ <p>{inline}</p>
+ </div>
+);
+
export default function LeftPanel({
setDataset,
schema,
@@ -223,13 +230,6 @@ export default function LeftPanel({
option?.value?.toLowerCase().includes(searchVal.toLowerCase()),
);
- const Loader = (inline: string) => (
- <div className="loading-container">
- <Loading position="inline" />
- <p>{inline}</p>
- </div>
- );
-
return (
<LeftPanelStyle>
<p className="section-title db-schema">Select database & schema</p>
diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx
index 032a9437e2..7721c63f8c 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx
@@ -65,6 +65,9 @@ export function datasetReducer(
}
}
+const prevUrl =
+ '/tablemodelview/list/?pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc';
+
export default function AddDataset() {
const [dataset, setDataset] = useReducer<
Reducer<Partial<DatasetObject> | null, DSReducerActionType>
@@ -81,8 +84,10 @@ export default function AddDataset() {
dbId={dataset?.db?.id}
/>
);
- const prevUrl =
- '/tablemodelview/list/?pageIndex=0&sortColumn=changed_on_delta_humanized&sortOrder=desc';
+
+ const DatasetPanelComponent = () => (
+ <DatasetPanel tableName={dataset?.table_name} />
+ );
const FooterComponent = () => (
<Footer url={prevUrl} datasetObject={dataset} />
@@ -92,7 +97,7 @@ export default function AddDataset() {
<DatasetLayout
header={HeaderComponent()}
leftPanel={LeftPanelComponent()}
- datasetPanel={DatasetPanel()}
+ datasetPanel={DatasetPanelComponent()}
footer={FooterComponent()}
/>
);
diff --git a/superset-frontend/src/views/CRUD/data/dataset/DatasetLayout/DatasetLayout.test.tsx b/superset-frontend/src/views/CRUD/data/dataset/DatasetLayout/DatasetLayout.test.tsx
index 2173f83fa0..78ac80fb50 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/DatasetLayout/DatasetLayout.test.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/DatasetLayout/DatasetLayout.test.tsx
@@ -57,7 +57,7 @@ describe('DatasetLayout', () => {
});
it('renders a DatasetPanel when passed in', () => {
- render(<DatasetLayout datasetPanel={DatasetPanel()} />);
+ render(<DatasetLayout datasetPanel={<DatasetPanel />} />);
const blankDatasetImg = screen.getByRole('img', { name: /empty/i });
const blankDatasetTitle = screen.getByText(/select dataset source/i);
[superset] 02/03: Debugging LeftPanel.test.tsx
Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a commit to branch lyndsi/table-selected-visuals
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 47bac70a64b86b346afc9e7fc1a6ec23fb9fda60
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Tue Oct 11 11:18:01 2022 -0500
Debugging LeftPanel.test.tsx
---
.../src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
index 2fe74b0068..3b2ef18181 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
@@ -19,7 +19,7 @@
import React from 'react';
import fetchMock from 'fetch-mock';
import userEvent from '@testing-library/user-event';
-import { render, screen, waitFor, within } from 'spec/helpers/testing-library';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
import LeftPanel from 'src/views/CRUD/data/dataset/AddDataset/LeftPanel';
const databasesEndpoint = 'glob:*/api/v1/database/?q*';
[superset] 01/03: Add client side searching to table list in dataset left panel
Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a commit to branch lyndsi/table-selected-visuals
in repository https://gitbox.apache.org/repos/asf/superset.git
commit fa4f6a4fd0d54f1b7b1cfa43d551ae4ade0a1c82
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Wed Sep 28 14:48:46 2022 -0500
Add client side searching to table list in dataset left panel
---
.../src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
index 3b2ef18181..2fe74b0068 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/LeftPanel.test.tsx
@@ -19,7 +19,7 @@
import React from 'react';
import fetchMock from 'fetch-mock';
import userEvent from '@testing-library/user-event';
-import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import { render, screen, waitFor, within } from 'spec/helpers/testing-library';
import LeftPanel from 'src/views/CRUD/data/dataset/AddDataset/LeftPanel';
const databasesEndpoint = 'glob:*/api/v1/database/?q*';