[I] Docker Compose v1 is hardcoded, so the compose launcher cannot run on current hosts [solr-orbit]

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy opened a new issue, #119:
URL: https://github.com/apache/solr-orbit/issues/119

   Three call sites invoke the standalone `docker-compose` binary: `builder/launcher.py`, `builder/launchers/docker_launcher.py`, and `check_prerequisites()` in `it/__init__.py`.
   
   That binary is Compose **v1**, which reached end of life in June 2023. Compose **v2** is a `docker compose` subcommand of the Docker CLI, and on current CI images and Linux distributions it is the only one installed — the standalone binary is simply absent. Older Docker Desktop installs still provide both, which is why this is invisible on a developer machine and fails everywhere else.
   
   Two consequences. Solr Orbit's compose-based launcher path cannot start a node on a host with only Compose v2. And the integration suite fails in `setup_module` before any test body runs, so every test in `it/` errors with `FileNotFoundError: [Errno 2] No such file or directory: 'docker-compose'` — which is exactly what the first run of the new integration-test workflow produced (17 errors in 1.34s, https://github.com/apache/solr-orbit/actions/runs/38913531221).
   
   The fix is to look for Compose v2 first and fall back to the v1 binary, so a host with either can run a benchmark, and to report a clear setup error when neither is present. `LocalShellExecutor` is the only executor, so the lookup can happen in-process.
   
   🤖 Assisted by Claude Code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

Re: [I] Docker Compose v1 is hardcoded, so the compose launcher cannot run on current hosts [solr-orbit]

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy closed issue #119: Docker Compose v1 is hardcoded, so the compose launcher cannot run on current hosts
URL: https://github.com/apache/solr-orbit/issues/119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org