You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2024/09/13 19:02:43 UTC
[PR] fix: unable to disallow csv upload on header menu [superset]
justinpark opened a new pull request, #30271:
URL: https://github.com/apache/superset/pull/30271
Fixes #30260
### SUMMARY
In the [#28192](https://github.com/apache/superset/pull/28192/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eL192), the CSV menu was changed from a page URL to a modal popup, which led to an issue where the popup could be triggered even when the menu was in a disabled state.
This commit addresses the problem by passing the disabled property to the menu, making it impossible to click.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://github.com/user-attachments/assets/38fa296c-090f-41da-902c-53ce95eb2c93
After:
https://github.com/user-attachments/assets/99f1420a-7bc0-4bc5-80e0-136d07dc9be1
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: unable to disallow csv upload on header menu [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #30271:
URL: https://github.com/apache/superset/pull/30271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org