You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kishore Gopalakrishna <ki...@apache.org> on 2015/03/03 01:42:53 UTC
Re: Review Request 31397: [HELIX-570] Add default state model
definitions if not already exists when controller starts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31397/#review74862
-----------------------------------------------------------
Ship it!
helix-core/src/main/java/org/apache/helix/model/BuildInSMD.java
<https://reviews.apache.org/r/31397/#comment121674>
rename to BuiltInStateModelDefinitions or StateModelDefinitionsProvided, we also have statemodeldefinitionBuilder, i think its will be nice to provide methods on the builder for every statemodel
- Kishore Gopalakrishna
On Feb. 26, 2015, 2:23 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31397/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 2:23 a.m.)
>
>
> Review request for helix, Kishore Gopalakrishna and Shi Lu.
>
>
> Bugs: 570
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> When controller starts, we can add missing default state model definitions to the cluster. This is useful for example, a legacy cluster is created without some new default state model definitions. Instead of building a tool to populate the new default state model definitions to existing clusters, controller can check this and add it if necessary.
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java b6c16b5
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java 3328279
> helix-core/src/main/java/org/apache/helix/model/BuildInSMD.java e69de29
> helix-core/src/main/java/org/apache/helix/model/LeaderStandbySMD.java e69de29
> helix-core/src/main/java/org/apache/helix/model/MasterSlaveSMD.java e69de29
> helix-core/src/main/java/org/apache/helix/model/OnlineOfflineSMD.java e69de29
> helix-core/src/main/java/org/apache/helix/model/ScheduledTaskSMD.java e69de29
> helix-core/src/main/java/org/apache/helix/model/StorageSchemataSMD.java e69de29
> helix-core/src/main/java/org/apache/helix/model/TaskSMD.java e69de29
> helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 40bc398
> helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java b8b3aeb
> helix-core/src/test/java/org/apache/helix/manager/zk/TestAddDefaultStateModelDef.java e69de29
>
> Diff: https://reviews.apache.org/r/31397/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>