[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5601: HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5601:
URL: https://github.com/apache/hadoop/pull/5601#discussion_r1178976624


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java:
##########
@@ -76,10 +76,9 @@ public class NameNodeHttpServer {
     this.bindAddress = bindAddress;
   }
 
-  public static void initWebHdfs(Configuration conf, String hostname,
-      String httpKeytab,
-      HttpServer2 httpServer2, String jerseyResourcePackage)
-      throws IOException {
+  public static void initWebHdfs(Configuration conf, HttpServer2 httpServer2,
+                                 String jerseyResourcePackage)
+          throws IOException {

Review Comment:
   code isn't formatted properly



##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java:
##########
@@ -159,9 +158,8 @@ void start() throws IOException {
       httpServer.setAttribute(DFSConfigKeys.DFS_DATANODE_HTTPS_PORT_KEY,
           datanodeSslPort.getPort());
     }
-    String httpKeytab = conf.get(DFSUtil.getSpnegoKeytabKey(conf,
-        DFSConfigKeys.DFS_NAMENODE_KEYTAB_FILE_KEY));
-    initWebHdfs(conf, bindAddress.getHostName(), httpKeytab, httpServer,
+
+    initWebHdfs(conf, httpServer,
         NamenodeWebHdfsMethods.class.getPackage().getName());

Review Comment:
   this even doesn't look properly formatted 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org