You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/09/19 06:37:24 UTC

[GitHub] [echarts-doc] plainheart commented on a diff in pull request #288: feat(treemap.breadcrumb.emphasis): add version

plainheart commented on code in PR #288:
URL: https://github.com/apache/echarts-doc/pull/288#discussion_r973902874


##########
en/option/series/treemap.md:
##########
@@ -169,6 +169,9 @@ When is no content in breadcrumb, this minimal width need to be set up.
 ) }}
 
 ### emphasis(*)
+{{ use: partial-version(
+    version = "5.4.0"
+) }}

Review Comment:
   It seems we also need to correct the default values of the following `itemStyle` object.
   
   https://github.com/apache/echarts-doc/blob/master/en/option/series/treemap.md?plain=1#L181-L188
   https://github.com/apache/echarts-doc/blob/master/en/option/series/treemap.md?plain=1#L155-L161
   
   https://github.com/apache/echarts/blob/release/src/chart/treemap/TreemapSeries.ts#L267-L277
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org