You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/03/15 13:45:48 UTC

Review Request 57642: Upgrade pre-checks screen does not show CONFIG_MERGE warning

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57642/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20449
    https://issues.apache.org/jira/browse/AMBARI-20449


Repository: ambari


Description
-------

STR
Deploy HDP-2.5.3 cluster with Ambari-2.5.0.1
Register HDP-2.6 version and install the bits
Click on Upgrade and click on Warning hyperlink for EU
Result: 
Shows 2 warnings for EU. Click on the Warning and it shows "only one warning" and the warning for CONFIG_MERGE pre-check does not show up
(see attachments)
From the output of pre-checks API call, I do see two warning for Config Merge as below:


Diffs
-----

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a760f0c 
  ambari-web/app/messages.js 1a26516 
  ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs 79e1de5 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_configs_recommend_table.hbs PRE-CREATION 
  ambari-web/app/views/common/modal_popups/cluster_check_popup.js a613f4b 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 1d88913 
  ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js d70379b 


Diff: https://reviews.apache.org/r/57642/diff/1/


Testing
-------

20570 passing (32s)
  153 pending


Thanks,

Andrii Tkach


Re: Review Request 57642: Upgrade pre-checks screen does not show CONFIG_MERGE warning

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57642/#review169009
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On \u041c\u0430\u0440\u0442 15, 2017, 1:45 \u043f.\u043f., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57642/
> -----------------------------------------------------------
> 
> (Updated \u041c\u0430\u0440\u0442 15, 2017, 1:45 \u043f.\u043f.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20449
>     https://issues.apache.org/jira/browse/AMBARI-20449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR
> Deploy HDP-2.5.3 cluster with Ambari-2.5.0.1
> Register HDP-2.6 version and install the bits
> Click on Upgrade and click on Warning hyperlink for EU
> Result: 
> Shows 2 warnings for EU. Click on the Warning and it shows "only one warning" and the warning for CONFIG_MERGE pre-check does not show up
> (see attachments)
> From the output of pre-checks API call, I do see two warning for Config Merge as below:
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a760f0c 
>   ambari-web/app/messages.js 1a26516 
>   ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs 79e1de5 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_configs_recommend_table.hbs PRE-CREATION 
>   ambari-web/app/views/common/modal_popups/cluster_check_popup.js a613f4b 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 1d88913 
>   ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js d70379b 
> 
> 
> Diff: https://reviews.apache.org/r/57642/diff/1/
> 
> 
> Testing
> -------
> 
> 20570 passing (32s)
>   153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>