You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/29 13:16:07 UTC

[GitHub] MaxGekk opened a new pull request #23406: [SPARK-26504][SQL] Rope-wise dumping of Spark plans

MaxGekk opened a new pull request #23406: [SPARK-26504][SQL] Rope-wise dumping of Spark plans
URL: https://github.com/apache/spark/pull/23406
 
 
   ## What changes were proposed in this pull request?
   
   Proposed new class `StringRope` for converting a sequence of strings to string with one memory allocation in the `toString` method.  `StringRope` replaces `StringBuilderWriter` in methods of dumping of Spark plans and codegen to strings.
   
   All `Writer` arguments are replaced by `String => Unit` in methods related to Spark plans stringification.  
   
   ## How was this patch tested?
   
   It was tested by existing suites `QueryExecutionSuite`, `DebuggingSuite` as well as new tests for `StringRope` in `StringUtilsSuite`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org