You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mod_python-dev@quetz.apache.org by "Graham Dumpleton (JIRA)" <ji...@apache.org> on 2005/07/22 13:41:51 UTC

[jira] Updated: (MODPYTHON-67) Make req.path_info writable.

     [ http://issues.apache.org/jira/browse/MODPYTHON-67?page=all ]

Graham Dumpleton updated MODPYTHON-67:
--------------------------------------

    Attachment: requestobject.c.diff

Patch for requestobject.c  which makes req.path_info writable.

> Make req.path_info writable.
> ----------------------------
>
>          Key: MODPYTHON-67
>          URL: http://issues.apache.org/jira/browse/MODPYTHON-67
>      Project: mod_python
>         Type: New Feature
>   Components: core
>     Versions: 3.2.0
>     Reporter: Graham Dumpleton
>  Attachments: requestobject.c.diff
>
> In current version of mod_python req.filename is writable, but
> req.path_info isn't.
> If req.path_info were writable it would more easily allow a middleware
> stack to be implemented in mod_python. This is because a middleware
> component could modify req.path_info as necessary as the path info is
> progressively processed. This would be better than a middleware
> component having to create a parallel request attribute just for this
> purpose as by being able to change req.path_info existing handlers such
> as mod_python.publisher which already look at req.filename and
> req.path_info could still be utilised in various ways within the
> middleware stack. Same for any handlers which third parties may have
> developed. Thus would eliminate the need to copy existing handlers and
> modify them to get them to work, a middleware component would simply
> need to setup req.filename and req.path_info as appropriate and the
> existing handlers would work unmodified.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (MODPYTHON-67) Make req.path_info writable.

Posted by Jim Gallacher <jg...@sympatico.ca>.
+1 on this for me.
If there are no objections I'll apply the patch and commit to svn.

Regards,
Jim

Graham Dumpleton (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/MODPYTHON-67?page=all ]
> 
> Graham Dumpleton updated MODPYTHON-67:
> --------------------------------------
> 
>     Attachment: requestobject.c.diff
> 
> Patch for requestobject.c  which makes req.path_info writable.
> 
> 
>>Make req.path_info writable.
>>----------------------------
>>
>>         Key: MODPYTHON-67
>>         URL: http://issues.apache.org/jira/browse/MODPYTHON-67
>>     Project: mod_python
>>        Type: New Feature
>>  Components: core
>>    Versions: 3.2.0
>>    Reporter: Graham Dumpleton
>> Attachments: requestobject.c.diff
>>
>>In current version of mod_python req.filename is writable, but
>>req.path_info isn't.
>>If req.path_info were writable it would more easily allow a middleware
>>stack to be implemented in mod_python. This is because a middleware
>>component could modify req.path_info as necessary as the path info is
>>progressively processed. This would be better than a middleware
>>component having to create a parallel request attribute just for this
>>purpose as by being able to change req.path_info existing handlers such
>>as mod_python.publisher which already look at req.filename and
>>req.path_info could still be utilised in various ways within the
>>middleware stack. Same for any handlers which third parties may have
>>developed. Thus would eliminate the need to copy existing handlers and
>>modify them to get them to work, a middleware component would simply
>>need to setup req.filename and req.path_info as appropriate and the
>>existing handlers would work unmodified.
> 
>