You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2026/09/06 21:38:15 UTC

[PR] test: cover remaining IN list paths [datafusion]

peterxcli opened a new pull request, #25001:
URL: https://github.com/apache/datafusion/pull/25001

   ## Which issue does this PR close?
   
   - Closes #23307.
   
   ## Rationale for this change
   
   The remaining specialized IN-list paths need SQL-level coverage to verify dispatch and end-to-end behavior.
   
   ## What changes are included in this PR?
   
   Adds SQL logic tests for:
   
   - generic `ArrayStaticFilter` values using lists
   - dictionary literal flattening
   
   The cases cover matches, non-matches, nulls, and `NOT IN` behavior where applicable.
   
   ## What is the testing strategy for this PR?
   
   - `cargo fmt --all`
   - `cargo test --test sqllogictests -- in_list`
   - `RUST_BACKTRACE=1 cargo test --profile ci --exclude datafusion-examples --exclude datafusion-benchmarks --exclude datafusion-cli --workspace --lib --tests --bins --features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption`
   
   `cargo clippy --all-targets --all-features -- -D warnings` was also run. It is currently blocked by an existing `clippy::needless_pass_by_value` warning in unchanged code at `datafusion/sqllogictest/src/engines/conversion.rs:99` (`decimal_to_str(BigDecimal)`) with the repository-pinned Rust 1.97 toolchain.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] test: cover ArrayStaticFilter and dictionary flattening IN list [datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #25001:
URL: https://github.com/apache/datafusion/pull/25001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] test: cover ArrayStaticFilter and dictionary flattening IN list [datafusion]

Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #25001:
URL: https://github.com/apache/datafusion/pull/25001#issuecomment-5573157751

   @jayzhan211 thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] test: cover remaining IN list paths [datafusion]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25001:
URL: https://github.com/apache/datafusion/pull/25001#issuecomment-5562502457

   ## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25001?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 81.67%. Comparing base ([`262936e`](https://app.codecov.io/gh/apache/datafusion/commit/262936eef50727753c47d1d1b3d86dea994c55f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c973ef8`](https://app.codecov.io/gh/apache/datafusion/commit/c973ef82c4e043295ebb6cd8f9f305b67a05a173?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main   #25001      +/-   ##
   ==========================================
   - Coverage   81.67%   81.67%   -0.01%     
   ==========================================
     Files        1126     1126              
     Lines      414842   414842              
     Branches   414842   414842              
   ==========================================
   - Hits       338841   338833       -8     
   - Misses      56070    56076       +6     
   - Partials    19931    19933       +2     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25001?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org