[jira] [Commented] (HIVE-13986) LLAP: kill Tez AM on token errors from plugin

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323430#comment-15323430 ] 

Siddharth Seth commented on HIVE-13986:
---------------------------------------

{code}
if (((cause instanceof InvalidToken && cause.getMessage() != null)
	          || (cause instanceof RemoteException && cause.getCause() == null
	              && cause.getMessage() != null && cause.getMessage().contains("InvalidToken")))
	          && cause.getMessage().contains(LLAP_TOKEN_NAME)) {
{code}
Is a closing bracket missed on the last line, and instead exists on the line above. i.e should this be
{code}
 && cause.getMessage() != null && cause.getMessage().contains("InvalidToken"))
	          && cause.getMessage().contains(LLAP_TOKEN_NAME)))
{code}

API usage looks good. If this makes sense, we can customize ServicePluginErrorDefaults.OTHER_FATAL to an enum defined in Hive which is more specific than OTHER_FATAL.

Can the method be called after logging from all the functions ?

> LLAP: kill Tez AM on token errors from plugin
> ---------------------------------------------
>
>                 Key: HIVE-13986
>                 URL: https://issues.apache.org/jira/browse/HIVE-13986
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-13986.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)