You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "danielhumanmod (via GitHub)" <gi...@apache.org> on 2025/03/14 05:35:18 UTC

[PR] Fix CI error for NotNull import [polaris]

danielhumanmod opened a new pull request, #1174:
URL: https://github.com/apache/polaris/pull/1174

   <!--
       Possible security vulnerabilities: STOP here and contact security@apache.org instead!
   
       Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
       Please update this summary field:
   
       The summary should cover these topics, if applicable:
       * the motivation for the change
       * a description of the status quo, for example the current behavior
       * the desired behavior
       * etc
   
       PR checklist:
       - Do a self-review of your code before opening a pull request
       - Make sure that there's good test coverage for the changes included in this PR
       - Run tests locally before pushing a PR (./gradlew check)
       - Code should have comments where applicable. Particularly hard-to-understand
         areas deserve good in-line documentation.
       - Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
       - For Work In Progress Pull Requests, please use the Draft PR feature.
   
       Make sure to add the information BELOW this comment.
       Everything in this comment will NOT be added to the PR description.
   -->
   # Summary 
   In #516, incorrect type of NotNull (`org.jetbrains.annotations.NotNull`) was used in the test, which caused errors in CI. This fix PR replaces it with the correct one `jakarta.annotation.Nonnull`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix CI error for NotNull import [polaris]

Posted by "danielhumanmod (via GitHub)" <gi...@apache.org>.
danielhumanmod commented on PR #1174:
URL: https://github.com/apache/polaris/pull/1174#issuecomment-2723680572

   Q: why this error did not be caught in origin PR?
   A: It seems fine on the PR’s CI check (https://github.com/apache/polaris/actions/runs/13536819440/job/38356607056). Perhaps there were some updates on CI config that weren’t synced and applied to this PR. 
   
   To prevent this from happening, we can recommend contributors sync the latest changes from main before merging or consider implementing a merge gate in the future.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix CI error for NotNull import [polaris]

Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard merged PR #1174:
URL: https://github.com/apache/polaris/pull/1174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org