You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/16 16:53:05 UTC
[jira] [Commented] (CB-9815) Engine name="cordova" should check
tools version, not platforms
[ https://issues.apache.org/jira/browse/CB-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960825#comment-14960825 ]
ASF GitHub Bot commented on CB-9815:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/324
CB-9815 Engine name="cordova" should check tools version, not platforms
https://issues.apache.org/jira/browse/CB-9815
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9815
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit f1ed58c18bac57dac9060666366cb0c69bfc0a3d
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-10-16T14:51:07Z
CB-9815 Engine name="cordova" should check tools version, not platforms
----
> Engine name="cordova" should check tools version, not platforms
> ---------------------------------------------------------------
>
> Key: CB-9815
> URL: https://issues.apache.org/jira/browse/CB-9815
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova-lib, engines, versioning
>
> If I use the following engine tag inside some of my plugins
> {code}
> <engine name="cordova" version=">=4.3.0" />
> {code}
> I see that the tools compares version w/ platforms versions when installing plugins, not the tools version.
> This is due to the following implementation. We should update implementation similar to cordova-plugman and threat cordova version as tools version not platforms.
> https://github.com/apache/cordova-lib/blob/d12be7c3e7b532bdea43321db2a3ce76b5f4d39f/cordova-lib/src/plugman/util/default-engines.js#L22
> {code}
> module.exports = function(project_dir){
> return {
> 'cordova':
> { 'platform':'*', 'scriptSrc': path.join(project_dir,'cordova','version') },
> 'cordova-plugman':
> { 'platform':'*', 'currentVersion': require('../../../package.json').version },
> 'cordova-android':
> { 'platform':'android', 'scriptSrc': path.join(project_dir,'cordova','version') },
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org