You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2016/04/27 15:00:49 UTC
svn commit: r1741249 - in /jackrabbit/oak/trunk/oak-segment-next/src:
main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
test/java/org/apache/jackrabbit/oak/segment/file/TarWriterTest.java
Author: mduerig
Date: Wed Apr 27 13:00:49 2016
New Revision: 1741249
URL: http://svn.apache.org/viewvc?rev=1741249&view=rev
Log:
OAK-4276: Refactor / rework compaction strategies
Remove unused method and corresponding test case
Removed:
jackrabbit/oak/trunk/oak-segment-next/src/test/java/org/apache/jackrabbit/oak/segment/file/TarWriterTest.java
Modified:
jackrabbit/oak/trunk/oak-segment-next/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
Modified: jackrabbit/oak/trunk/oak-segment-next/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-next/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java?rev=1741249&r1=1741248&r2=1741249&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-next/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java (original)
+++ jackrabbit/oak/trunk/oak-segment-next/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java Wed Apr 27 13:00:49 2016
@@ -477,30 +477,6 @@ class TarWriter implements Closeable {
return header;
}
- // FIXME OAK-4276: Refactor / rework compaction strategies
- // This method is not used anymore. Remove unless we decide
- // to offer an alternative cleanup strategy based on reachability, in which
- // case it will still be needed
- /**
- * Add all segment ids that are reachable from {@code referencedIds} via
- * this writer's segment graph and subsequently remove those segment ids
- * from {@code referencedIds} that are in this {@code TarWriter}. The
- * latter can't be cleaned up anyway because they are not be present in
- * any of the readers.
- *
- * @param referencedIds
- */
- synchronized void collectReferences(Set<UUID> referencedIds) {
- for (UUID uuid : reverse(newArrayList(index.keySet()))) {
- if (referencedIds.remove(uuid)) {
- List<UUID> refs = graph.get(uuid);
- if (refs != null) {
- referencedIds.addAll(refs);
- }
- }
- }
- }
-
//------------------------------------------------------------< Object >--
@Override