You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Rajith Attapattu <ra...@gmail.com> on 2007/10/11 14:35:20 UTC
Re: svn commit: r583785 - /incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
Arnaud,
I am not sure if this line is needed. Each time we unsuspend a channel or
each time the flow mode is changed we set this.
_0_10session.getQpidSession().messageFlow(getConsumerTag().toString(),
Session.MESSAGE_FLOW_UNIT_BYTE, 0xFFFFFFFF);
Was this in response to a particular issue?
Regards,
Rajith
On 10/11/07, arnaudsimon@apache.org <ar...@apache.org> wrote:
>
> Author: arnaudsimon
> Date: Thu Oct 11 05:01:50 2007
> New Revision: 583785
>
> URL: http://svn.apache.org/viewvc?rev=583785&view=rev
> Log:
> added byte credits when no message is reeived
>
> Modified:
>
> incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
>
> Modified:
> incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> URL:
> http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java?rev=583785&r1=583784&r2=583785&view=diff
>
> ==============================================================================
> ---
> incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> (original)
> +++
> incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> Thu Oct 11 05:01:50 2007
> @@ -376,6 +376,7 @@
> // checking if one is inflight
>
> _0_10session.getQpidSession().messageFlush(getConsumerTag().toString());
> _0_10session.getQpidSession().sync();
>
> + _0_10session.getQpidSession().messageFlow(getConsumerTag().toString(),
> Session.MESSAGE_FLOW_UNIT_BYTE, 0xFFFFFFFF);
> o = _synchronousQueue.poll();
> }
> }
>
>
>
Re: svn commit: r583785 -
/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
Posted by Arnaud Simon <as...@redhat.com>.
On Thu, 2007-10-11 at 08:38 -0400, Rajith Attapattu wrote:
> Arnaud,
>
> Figured it out, the flush will actually exhaust all credit, so we need to
> add byte credits again.
>
> Regards,
>
> Rajith
Great, I did not even have to reply :)
> On 10/11/07, Rajith Attapattu <ra...@gmail.com> wrote:
> >
> > Arnaud,
> >
> > I am not sure if this line is needed. Each time we unsuspend a channel or
> > each time the flow mode is changed we set this.
> > _0_10session.getQpidSession().messageFlow(getConsumerTag().toString(),
> > Session.MESSAGE_FLOW_UNIT_BYTE , 0xFFFFFFFF);
> > Was this in response to a particular issue?
> >
> > Regards,
> >
> > Rajith
> >
> > On 10/11/07, arnaudsimon@apache.org <ar...@apache.org> wrote:
> > >
> > > Author: arnaudsimon
> > > Date: Thu Oct 11 05:01:50 2007
> > > New Revision: 583785
> > >
> > > URL: http://svn.apache.org/viewvc?rev=583785&view=rev
> > > Log:
> > > added byte credits when no message is reeived
> > >
> > > Modified:
> > >
> > > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> > >
> > > Modified:
> > > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> > >
> > > URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java?rev=583785&r1=583784&r2=583785&view=diff
> > >
> > >
> > > ==============================================================================
> > > ---
> > > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> > > (original)
> > > +++
> > > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> > > Thu Oct 11 05:01:50 2007
> > > @@ -376,6 +376,7 @@
> > > // checking if one is inflight
> > >
> > > _0_10session.getQpidSession().messageFlush(getConsumerTag().toString());
> > > _0_10session.getQpidSession().sync();
> > >
> > > + _0_10session.getQpidSession().messageFlow(getConsumerTag().toString(),
> > > Session.MESSAGE_FLOW_UNIT_BYTE, 0xFFFFFFFF);
> > > o = _synchronousQueue.poll();
> > > }
> > > }
> > >
> > >
> > >
> >
Re: svn commit: r583785 - /incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
Posted by Rajith Attapattu <ra...@gmail.com>.
Arnaud,
Figured it out, the flush will actually exhaust all credit, so we need to
add byte credits again.
Regards,
Rajith
On 10/11/07, Rajith Attapattu <ra...@gmail.com> wrote:
>
> Arnaud,
>
> I am not sure if this line is needed. Each time we unsuspend a channel or
> each time the flow mode is changed we set this.
> _0_10session.getQpidSession().messageFlow(getConsumerTag().toString(),
> Session.MESSAGE_FLOW_UNIT_BYTE , 0xFFFFFFFF);
> Was this in response to a particular issue?
>
> Regards,
>
> Rajith
>
> On 10/11/07, arnaudsimon@apache.org <ar...@apache.org> wrote:
> >
> > Author: arnaudsimon
> > Date: Thu Oct 11 05:01:50 2007
> > New Revision: 583785
> >
> > URL: http://svn.apache.org/viewvc?rev=583785&view=rev
> > Log:
> > added byte credits when no message is reeived
> >
> > Modified:
> >
> > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> >
> > Modified:
> > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> >
> > URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java?rev=583785&r1=583784&r2=583785&view=diff
> >
> >
> > ==============================================================================
> > ---
> > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> > (original)
> > +++
> > incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer_0_10.java
> > Thu Oct 11 05:01:50 2007
> > @@ -376,6 +376,7 @@
> > // checking if one is inflight
> >
> > _0_10session.getQpidSession().messageFlush(getConsumerTag().toString());
> > _0_10session.getQpidSession().sync();
> >
> > + _0_10session.getQpidSession().messageFlow(getConsumerTag().toString(),
> > Session.MESSAGE_FLOW_UNIT_BYTE, 0xFFFFFFFF);
> > o = _synchronousQueue.poll();
> > }
> > }
> >
> >
> >
>