You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/26 00:46:41 UTC

[GitHub] [arrow] kou commented on a change in pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

kou commented on a change in pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#discussion_r476921895



##########
File path: cpp/src/arrow/util/decimal_test.cc
##########
@@ -384,10 +389,10 @@ static const ToStringTestData kToStringTestData[] = {
     {-1234567890123456789LL, 25, "-1.234567890123456789E-7"},
 };
 
-class Decimal128ToStringTest : public ::testing::TestWithParam<ToStringTestData> {};
+class Decimal128ToStringTest : public ::testing::TestWithParam<ToStringTestParam> {};
 
 TEST_P(Decimal128ToStringTest, ToString) {
-  const ToStringTestData& data = GetParam();
+  const ToStringTestParam& data = GetParam();

Review comment:
       How about changing local variable name to `param` from `data` too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org