You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/26 20:18:30 UTC

[GitHub] codecov-io edited a comment on issue #3543: Segment merge lineage data structure

codecov-io edited a comment on issue #3543: Segment merge lineage data structure
URL: https://github.com/apache/incubator-pinot/pull/3543#issuecomment-441782606
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=h1) Report
   > Merging [#3543](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/ce6a53fac7882badeef45deac3407d33e331416f?src=pr&el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `79.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3543/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3543      +/-   ##
   ============================================
   - Coverage     70.89%   70.77%   -0.13%     
     Complexity        4        4              
   ============================================
     Files           998     1001       +3     
     Lines         45669    45836     +167     
     Branches       6108     6132      +24     
   ============================================
   + Hits          32379    32442      +63     
   - Misses        11176    11268      +92     
   - Partials       2114     2126      +12
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...edin/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRhZGF0YS9aS01ldGFkYXRhUHJvdmlkZXIuamF2YQ==) | `66.45% <0%> (-3.55%)` | `0 <0> (ø)` | |
   | [...ommon/lineage/SegmentMergeLineageAccessHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9saW5lYWdlL1NlZ21lbnRNZXJnZUxpbmVhZ2VBY2Nlc3NIZWxwZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...om/linkedin/pinot/common/lineage/SegmentGroup.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9saW5lYWdlL1NlZ21lbnRHcm91cC5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...edin/pinot/common/lineage/SegmentMergeLineage.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9saW5lYWdlL1NlZ21lbnRNZXJnZUxpbmVhZ2UuamF2YQ==) | `85.4% <85.4%> (ø)` | `0 <0> (?)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
   | [...core/operator/dociditerators/AndDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL0FuZERvY0lkSXRlcmF0b3IuamF2YQ==) | `51.72% <0%> (-31.04%)` | `0% <0%> (ø)` | |
   | [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
   | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `51.42% <0%> (-18.58%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `80% <0%> (-13.34%)` | `0% <0%> (ø)` | |
   | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9PckJsb2NrRG9jSWRTZXQuamF2YQ==) | `84.9% <0%> (-13.21%)` | `0% <0%> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-pinot/pull/3543/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=footer). Last update [ce6a53f...e553144](https://codecov.io/gh/apache/incubator-pinot/pull/3543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org